Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

no longer prompted to save wallet recovery file #12508

Closed
LaurenWags opened this issue Jan 5, 2018 · 4 comments · Fixed by #12555
Closed

no longer prompted to save wallet recovery file #12508

LaurenWags opened this issue Jan 5, 2018 · 4 comments · Fixed by #12555
Assignees
@darkdh
Labels
0.19.x issue first seen in 0.19.x bug feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Milestone
0.20.x (Release C...

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Jan 5, 2018 •
edited by srirambv
Loading

Test plan

  1. Clean install 0.20.x
  2. Enable payments.
  3. Open Adv Settings
  4. Select Backup your wallet
  5. Select Save recovery file, save file prompt should open and backup file should be saved

Description

In 0.19.123 when you select Backup your wallet > Save recovery file... you are prompted to save the file. In 0.19.125 when you do these same steps, the file opens in a new tab and you are not prompted to save. (Print key/Save recovery file... have the same outcome, opening the file in a new tab)

Steps to Reproduce

  1. Clean install 0.19.125
  2. Enable payments.
  3. Open Adv Settings
  4. Select Backup your wallet
  5. Select Save recovery file...

Actual result:
File is opened in a new tab:
walletbackup-019125

Expected result:
You should be prompted to save the file:
walletbackup-019123

Reproduces how often:
Easily

Brave Version

about:brave info:
Brave | 0.19.125
rev | d81a458
Muon | 4.5.34

Reproducible on current live release:
no

Additional Information
@NejcZdovc
Copy link
Contributor

I checked out code that was changed in b-l and I can't find anything that could cause it. Is it possible that there was something changed in Muon? @bsclifton @darkdh

@bsclifton
Copy link
Member

bsclifton commented Jan 5, 2018 •
edited
Loading

Manually cherry picked in #11531 (which was missing). This should fix the issue. Will test locally and close issue if so 😄

UPDATE: reverted after realizing this is not a PDF 😛

@bsclifton
Copy link
Member

Also present in 0.20.x... I'd like to propose pushing the issue to that release

@bsclifton bsclifton modified the milestones: 0.19.x Hotfix 11 (Release Channel), 0.20.x (Beta Channel), 0.19.x Hotfix 12 Jan 5, 2018
@cezaraugusto
Copy link
Contributor

cc @darkdh I recall you fixed system prompt a while ago and may have some thoughts

darkdh added a commit that referenced this issue Jan 8, 2018
@darkdh
Check nullity of webcontents and empty url from getURL()
4316345 
#12508 is caused by empty
url which will leads to sending {cancel: true} to callback of
`session.webRequest.onBeforeRequest` and download process will be
aborted.
Also verified this won't break the issues which
#12256 fixes

fix #12508

Auditors: @bridiver, @diracdeltas, @bsclifton
@darkdh darkdh mentioned this issue Jan 8, 2018
Merged
10 tasks
@LaurenWags LaurenWags mentioned this issue Jan 22, 2018
Closed
34 tasks
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
0.19.x issue first seen in 0.19.x bug feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Check nullity of webcontents and empty url from getURL() brave/browser-laptop
7 participants
@kjozwiak @cezaraugusto @bsclifton @NejcZdovc @darkdh @srirambv @LaurenWags