This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Don't ignore internal requests in app/filtering #12256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and return details.firstPartyUrl as a fallback for main frame URL. Internal requests (tabId == -1) were ignored in order to fix #5934 in 6023abd. However (1) #5934 works without ignoring internal requests now and (2) generally speaking, non-webview requests should also be protected by HTTPS Everywhere, etc. fix #12253 fix #12252 Test Plan: 1. confirm HTTPS Everywhere and Safebrowsing are working using the test plans in #12253 and #12252 2. confirm that #5934 has not regressed by enabling Pocket
|
This PR can stay open until we merge C63 to master/0.19.x 😄 As noted above, it's already contained in the 0.19.x with Chromium 63 build (merged with #12255) |
bsclifton
added a commit
that referenced
this pull request
Dec 15, 2017
Don't ignore internal requests in app/filtering
bsclifton
added a commit
that referenced
this pull request
Dec 15, 2017
Don't ignore internal requests in app/filtering
darkdh
added a commit
that referenced
this pull request
Jan 8, 2018
#12508 is caused by empty url which will leads to sending {cancel: true} to callback of `session.webRequest.onBeforeRequest` and download process will be aborted. Also verified this won't break the issues which #12256 fixes fix #12508 Auditors: @bridiver, @diracdeltas, @bsclifton
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #12255 for master, 0.21.x, 0.20.x, and 0.19.x
and return details.firstPartyUrl as a fallback for main frame URL.
Internal requests (tabId == -1) were ignored in order to fix #5934 in 6023abd. However (1) #5934 works without ignoring internal requests now and (2) generally speaking, non-webview requests should also be protected by HTTPS Everywhere, etc.
fix #12253
fix #12252
Test Plan:
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests