Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Payments Never Contributes #13156

Open
MoonRubles opened this issue Feb 15, 2018 · 116 comments
Open

Payments Never Contributes #13156

MoonRubles opened this issue Feb 15, 2018 · 116 comments
Assignees
Labels
feature/rewards needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release.

Comments

@MoonRubles
Copy link

Description

Brave Payments keeps saying "next contribution on X", but when that date rolls around the date is advanced a month, still says "no previous contribution" and the balance in BAT has not changed. This has happened for a least 3 months.
All similar issues I see are marked closed.

Steps to Reproduce

  1. windows 10, always kept updated, brave also allowed to update when available.
  2. add funds to wallet: "your wallet is ready!"
  3. payments on
  4. monthly budget is non-zero, and balance is much greater than monthly budget. see screenshot. "Next contribution Feb 16"
  5. Date for next contribution arrives, next contribution date advances 1 month, balance doesnt change, no last contribution.
  6. For two months, I had set the pinned percentages to add up to 100%, so other entries would be zero if auto include were on. For the next month, made sure the pinned percentages were less than 100%, so some "zero" type error might be prevented. Same behavior.

Actual result:

bravepaymentcapture180215

Expected result:

The balance should reduce when a payment date occurs, and there should be a record of past contributions.

Reproduces how often:

Always. 3 or 4 months/attempts

Brave Version

about:brave info:

Brave: 0.20.30
V8: 6.4.388.40
rev: 8b78402
Muon: 4.7.9
OS Release: 10.0.16299
Update Channel: Release
OS Architecture: x64
OS Platform: Microsoft Windows
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 64.0.3282.119

Reproducible on current live release:

Im not sure what a live build is. Brave has updated several times over the duration of this problem (~Nov 2017 - Feb 2018)

Additional Information

@BobT36
Copy link

BobT36 commented Feb 15, 2018

I'm having the exact same issue, for at least 3 months now my contributions have never actually been contributed. There are no contributions in my history and my balance has never gone down.

capture

I have 47.50 BAT in my wallet. I have it set to contribute up to 50 BAT. I have a single YouTube channel there, verified, and Included. The payment set to 100%.

I expect as the date rolls around (Feb 16th previously), that it will send the payment (all my BAT) to the Youtube's Uphold account.

The actual result is it does not, it simply rolls the date forward (Now showing March 17th).

Am I doing something wrong?

OS: Windows 7 Ultimate x64.
Version Info:
Brave: 0.20.42
V8: 6.4.388.41
rev: 096c7cb
Muon: 4.8.2
OS Release: 6.1.7601
Update Channel: Release
OS Architecture: x64
OS Platform: Microsoft Windows
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 64.0.3282.140

@rjro
Copy link

rjro commented Feb 16, 2018

Same, I was "Overdue" and now my next contribution date is set to next month. I also recently learned that payments aren't sent out until the 30th, so the actual date of your contribution doesn't matter, only that is within that timeframe. I wish they would be more transparent about this whole system. FWIW I'm on Mac.

I mean this is supposed to be the entire purpose for this browser to exist and it doesn't work, and it seems to appear frequently in the community. Would be great to have this fixed and a little more info.

@NejcZdovc NejcZdovc added this to the 0.21.x (Beta Channel) milestone Feb 16, 2018
@NejcZdovc NejcZdovc self-assigned this Feb 16, 2018
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Feb 16, 2018

@MoonRubles @BobT36 @rjro can you please go to Advance settings (gear icon on the payments page) and click Backup your wallet. Do you see something like this auditioning parchment facing infliction experimental detente surreal quadrangular embalming throwing linchpin missouri kadishim pee treacherously reward (of course you will have different words?

@rjro
Copy link

rjro commented Feb 16, 2018

Yep, my wallet seed is still there.

@MoonRubles
Copy link
Author

@NejcZdovc Yes, i have a nice long recovery key like you describe

@BobT36
Copy link

BobT36 commented Feb 16, 2018

@NejcZdovc Hmm, I previously had the full key there, but now it only shows "a"...

Is there anything I can do here?

@LaurenWags
Copy link
Member

LaurenWags commented Feb 20, 2018

@alexwykoff alexwykoff added needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. priority/P2 Crashes. Loss of data. Severe memory leak. labels Feb 20, 2018
@eljuno
Copy link
Contributor

eljuno commented Feb 21, 2018

So, +1 from me. 😄

Claimed two grants so I have 47,5 BAT on my Brave wallet. When claimed the first grant, contribution date is Overdue << I enable payments but not add funds for months. Date is not updated but I know it should be sent after 30 days.

In January, the date changed to Jan 20, then I claimed the second grant and the date pushed again to Feb 18. On Feb 18, date changed to Today, but the contribution never sent.

And now it said Overdue. I set 50 BAT as monthly budget in case that matter. Also backup code show the correct words.

@BobT36
Copy link

BobT36 commented Feb 21, 2018

@eljuno Exactly the same as me. Same amount of bat, same budget, never paid out to the wallet I set.

Only difference is my wallet backup code only shows "a". I previously restored it from a backup as I switched computers, it showed fine at the time.

@evq
Copy link
Member

evq commented Feb 21, 2018

@BobT36 I would recommend that you re-restore from your backup. If the wallet backup code shows up as "a" it is expected that you would not be able to contribute.

@BobT36
Copy link

BobT36 commented Feb 21, 2018

@evq Thanks, fortunately I still had the backup file. Now shows my key correctly.

Hopefully it will actually make the contribution at some point.. I have a Youtube channel linked to a wallet pinned, with it set as Included and at 100%. As in the screenshot above really. (47.50 bat, 50 bat budget).

@evq
Copy link
Member

evq commented Feb 22, 2018

@BobT36 @eljuno I wanted to check in on your contributions, while rereading this topic I realized that you both said that you set your budget to 50 BAT when you only have 47.5 BAT in grants.

You'll need to set your budget lower than the amount you have in order for the contribution to go through. The monthly budget is not "up to 50 BAT", it is "50 BAT". Please let me know if that does not allow your contribution to go through. Edit: This is wrong, it should still go through.

Note that depending on when your second grant was accepted, you may have to wait a few more days for your contribution to be allowed through.

We are investigating the issue where the contribution date gets pushed back by 30 days when the contribution fails, this is not the intended behavior.

@eljuno
Copy link
Contributor

eljuno commented Feb 22, 2018

@evq if I read and assume the FAQ correctly, if I have balance at least 90% of the monthly budget, it should be sent? https://brave.com/faq-payments/#user-notification

Also, it seems the contribution's sent today. 0 BAT on balance and contribution date pushed to next month. But I'm not receive any notification like your contribution sent and no history (see that grey clock icon).

sent-230218

@evq
Copy link
Member

evq commented Feb 22, 2018

@eljuno You are correct, I was mistaken re: 90% of the contribution. I had originally believed that logic was not applying for grants but it is.

You should see the history and your notification appear soon. When there is not yet a statement this means that your browser is still in the voting process, there is a random delay element to this for anonymization purposes so it can take up to a few hours.

@eljuno
Copy link
Contributor

eljuno commented Feb 22, 2018

Thanks for clarifying @evq. Will waiting for notification and history. I'll keep an eye on it and will notify you if it still not appear after a few hours/days. 😄

@BobT36
Copy link

BobT36 commented Feb 22, 2018

Mine still hasn't sent yet:
capture
Then again I only just restored my wallet when I posted, so that could have been affecting things.
It now correctly still shows the full seed now, rather than just "a", so hopefully at some point it will actually happen.

I accepted both grants and had it set to do this for a good couple of months now, but it always just kept getting pushed back. Both December, January & Feb payments were missed.

@elsaber
Copy link

elsaber commented Feb 23, 2018

Same issue.

Brave 0.20.42
V8 6.4.388.41
rev 096c7cb
Muon 4.8.2
OS Release 4.13.0-32-generic
Update Channel Release
OS Architecture x64
OS Platform Linux
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 64.0.3282.140

screenshot from 2018-02-23 22-46-42

UPD (Feb. 24, 2018): My contribution has just been processed.

@NejcZdovc
Copy link
Contributor

I think that contributions are now going trough, so will close this issue for now. Let's reopen it if we find any problems.

@cryptojennie
Copy link

+1 from community https://basicattentiontoken.rocket.chat/channel/general?msg=yytc2vgQr67b6vhyb

+1 from me as well, where my contribution got pushed away a month as well.

@LaurenWags
Copy link
Member

+1 from community: https://community.brave.com/t/brave-payment-never-went-out/16905

@LaurenWags LaurenWags reopened this Feb 26, 2018
@BobT36
Copy link

BobT36 commented Feb 26, 2018

Mine still haven't sent. It's now showing March 17th. When can I expect it to?

@evq
Copy link
Member

evq commented Jun 2, 2018

@BobT36 glad that went through for you. I opened an issue to track the statement/receipt discrepancy you noted - #14319

FYI you may not see the balance go through to your publisher Uphold wallet until the 8th of next month. We make bulk settlements once a month and this contribution was right on the edge of the cutoff for the payout for June.

@evq
Copy link
Member

evq commented Jun 3, 2018

@NumDeP We deposited funds for grants into user's browser wallets - not the publishers they're trying to pay. The latter is impossible due to the privacy guarantees we designed into our contributions system (namely we cannot identify that a given user has (or desires to) contribute to any given website/publisher)

As far as the threshold requirement goes, I would strongly recommend opening a new issue for this feature suggestion. This is the first time I've heard it, a separate issue would help us gauge interest, circulate for internal discussion, etc. Thanks for the suggestion.

@BobT36
Copy link

BobT36 commented Jun 3, 2018

Oof, while to wait then, but like I said I don't mind. Just remind me to check next month and I'll confirm whether it worked.

Is there anything else you need from me to help testing / diagnosis? I've added my receipt and info to the issue you created.

Also as to the threshold rules, I'd second that it should work like so:

On budget change to one higher than the balance, display prompt to user: "Warning, this will use your total balance of 54.34BAT", then if ok'd, distribute the entire balance. Silly having like 3 BAT leftover or whatever. If user declines, reset the Budget to whatever it was previously.

@BobT36
Copy link

BobT36 commented Jun 6, 2018

Just got an additional 15 free BAT today. :)

My next contribution date is 30th June. Have set budget to 15 this time since it matches bang on.

I'll hold off if need be though (since it shows I have till 10th October) Anything specific you guys want me to test? (Higher budget thresholds or whatever), or shall I just let them go through on the 30th.

@realuser
Copy link

Well, after several months (maybe 4?) my payment finally contributed!

@NumDeP
Copy link

NumDeP commented Jul 20, 2018

Hi @evq I've got a question about the ledger. I have 35 BATs in my wallet, given the closest figures are 20 and 50 BATs, naturally contribution would go through if 20 is selected but what would happen if I left it at 50? I understand it doesn't fit the 90% threshold but what would happen, wouldn't the contributions go through at all and would I have to wait another month?

I've actually got a another question related to this but it's more befitting in the other topic I created a while back and updated recently, would you mind checking it out, I've cc'd you the comments there.

One other point, it isn't a huge issue but I thought I should report it for your information that the client notified me of my contribution being transferred in less than 24 hours today, however my client has always indicated that the 'Next contribution date: July 22nd', I don't mind it being 48 hours early but is it an error?

UPDATE: The same 24 hours notification appeared again 24 hours later and after that Overdue.

@BobT36
Copy link

BobT36 commented Jul 21, 2018

Alright so this is a weird situation...

  1. @evq That previous payment of 47.50 BAT still hasn't actually come through. However apparently 15 days ago a payment of 21 BAT was made to my Uphold (seems it was auto-converted to GBP too, so it's now only worth 16. Bah. I've now changed that setting for the future.):
    capture
    Brave Publisher statement for this year shows only that one 21.66 BAT payment being sent also. Now wasn't this supposed to be 47.50? If it's the same payment.. The only activity Brave browser shows in my history is that one 47.50 payment. (The receipt now shows the correct amount at least).

  2. Also since then, I've accrued 35 BAT from the free promotion in Brave (shame there's no setting to send it all, so I had to set 20). It had a payment date set to the 20th July, but is now just showing "Overdue":
    capture1

@disfit
Copy link

disfit commented Jul 26, 2018

Chiming in on this issue with small differences or different behavior. First of all, I am currently on:

Brave: 0.23.39
V8: 6.7.288.46
rev: 3ee14b0
Muon: 7.1.6
OS Release: 4.15.0-29-generic
Update Channel: Release
OS Architecture: x64
OS Platform: Linux
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 67.0.3396.103

I have had payments go through and have had issues in the past with my wallet & payments, see for instance issue #12122 (and in mails to @evq and @bsclifton: permission to share if useful). At this moment I have missed 2 consecutive payment windows. My partial contribution overview:

screenshot from 2018-07-26 09-00-57

After my last payment in May I claimed free tokens in June and then again in July. No screenshot for June, but here the before and after free-token-claim for July:

Before:
screenshot from 2018-07-07 08-03-00

After:
screenshot from 2018-07-07 08-03-42

At this moment the status has flipped to overdue again:
screenshot from 2018-07-26 09-07-20

Two possibly related issues:
I have noticed that it takes a longer time to load the payment screen (or parse the ledger). This now takes multiple seconds. This is also true for the Advanced Settings: here not for opening the pop up, but closing it. And the same is true for the Payment History pop up.

More troubling is that the recovery key for my wallet has changed at a certain moment. When I restore my wallet with the earlier recovery key I get a pop up that reports successful recovery. Yet the recovery key shown will still be the new one. Recovering my wallet with that new recovery key gives me a pop up with an error.

As before: I am happy to supply more information, logs and other help I can give.

@BobT36
Copy link

BobT36 commented Jul 26, 2018

Hmm not noticed any slowdown, however yes my recovery key is definitely different also. It's now a completely different (but valid looking) key than I had previously, as I backed it up when I was talking about it earlier in this thread.

My payments are still listed as overdue btw. I'm concerned that my 35 BAT from the free promotion will expire at some point. There's also the issue of the missing 26 BAT still outstanding..

@BobT36
Copy link

BobT36 commented Aug 19, 2018

So a couple of days ago I was getting constant popups that "Brave will pay your selected publishers in 24 hours" or something similar. It sat as "Overdue" for a couple of days in that time.

Now, it shows:

capture
So is it actually going to pay or what? I'm worried that the expiry dates are closing in..

@disfit
Copy link

disfit commented Aug 20, 2018

Same behavior here, though not pop ups, but a notification above the bookmark bar. Dismissing the notifications did not work as intended: the notification came back again and again.

My payment screen is also stating that the next contribution will be on September 17th and has been saying that since August 18th. However no August payment is showing in the history:

screenshot from 2018-08-20 08-25-13

@BobT36
Copy link

BobT36 commented Aug 20, 2018

Sorry I should have clarified it was a "notification" rather than a "pop-up". Basically the bar at the top that says payments would be sent in the next 24 hours blabblabla. I also had the same experience as @disfit where upon clicking dismiss, it kept coming back every now and again.

Seems we're both having the exact same experience here then.

@BobT36
Copy link

BobT36 commented Aug 29, 2018

So I claimed some more free BAT last night, however my payment date has now moved forward, again.. Also it's still not sent any of the previous lot for the last few months yet.

Only one month to go and then it starts expiring...
capture

@bsclifton bsclifton modified the milestones: Backlog (Prioritized), Triage Backlog Sep 18, 2018
@BobT36
Copy link

BobT36 commented Sep 23, 2018

So September 20th rolls around, it pops up the notification bar saying it's going to be paid within 24 hours, then...
capture

@evq @NejcZdovc any word on what's going on here? My BAT is going to start Expiring soon... :|

@jacobrosenthal
Copy link

Likewise. Ive taken like 5 grants and seen this happen every time. I got the pop up, the payment overdue, etc, etc. A bunch of funds disappeared from the account balance so maybe something happened? But I still don't have a payment history

@BobT36
Copy link

BobT36 commented Sep 23, 2018

@jacobrosenthal They could have just expired. See the dates, 15 of mine will expire in October, then 20 in November, then the rest in Jan lol. It's been like this for months.

@jacobrosenthal
Copy link

Im sure most of them have over the past 6 months as I dont think any of my payments have gone through. However the most recent ones werent due to expire until like oct/nov or something if I recall. But who knows, they disappeared.

@NumDeP
Copy link

NumDeP commented Sep 24, 2018

I'm sure most you are aware by now that they're soon going to deprecate Brave-Laptop-Moun for Brave-Browser-Core which they've coherently working liked mad dogs on and they're really close to v1.0. If you have a look at their Road Map, they're close to completing all of the tasks situated for it.

In addition to this, I believe the new Brave will include the new 'overhauling of Brave Payments as Brave Rewards'. So I highly doubt anything major will be worked on this version which we're all experiencing issues with, as I suspect any action will take the resources away from Brave Rewards which I anticipate to be far more effective and functional.

Think of it like this, we're going to most likely experience a far better Brave in less time than the next expiry date of funds or possibly the next contribution date.

@BobT36
Copy link

BobT36 commented Sep 24, 2018

@NumDeP Uh is "Brave-Laptop-Moun" the current desktop version? And I presume "Brave-Browser-Core" is the in-dev one? Not really kept track of it sorry.

And my funds first start expiring in 6 days...

@kjozwiak
Copy link
Member

@BobT36 & @jacobrosenthal,

Could you please PM your paymentId using Brave Community? Here's my username that you can PM:

You can retrieve you're paymentId from the following locations:

  • macOS - ~/Library/Application\ Support/brave/ledger-state.json
  • Win - C:\Users\[user name]\AppData\Roaming\brave
  • Linux - ~/.config/brave/ledger-state.json

Should look something like the following:

      },
      "paymentId": "014f077e-f6ca-467d-adf8-d4de042bae0b",
      "addresses": {
        "BAT": "0x0f054F834cbeF78A1F1E07286E36364dd14836be",
        "BTC": "1AHc5819BSQUbt9LGdh9HFEa2Xo84e5Zi1",
        "CARD_ID": "5497a4ab-358b-4f30-86dc-5d182a7e4126",
        "ETH": "0x0f054F834cbeF78A1F1E07286E36364dd14836be",
        "LTC": "LRjpnJzAnq8NdpFLvWbd1sAjrSkVZMqMAU"
      }

Once we get the paymentId, we'll take a look and see if we can figure out what's going on with your wallets 👍

@BobT36
Copy link

BobT36 commented Sep 25, 2018

Done, thanks! Happy to assist otherwise.

@BobT36
Copy link

BobT36 commented Nov 7, 2018

Well, it's now started expiring lol..

I'm now 35 BAT down. Gone, expired, not sent or anything:
capture

@NumDeP
Copy link

NumDeP commented Nov 7, 2018

I was completely cleaned out and it didn't contribute to any of the publishers as well. Pity I couldn't backup the BATs onto Brave-Cores's Rewards. Still at least they were kind enough to give us the BATs to test it out.

@BobT36 They've go a server issue and a couple of UI/UX related bugs in Rewards but I'm pretty sure after those are fixed, the system would be more stable than any of us have ever experienced.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/rewards needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release.
Projects
None yet
Development

No branches or pull requests