Support jump lists

[bsclifton]

Did you search for similar issues before submitting this one?
YEs

Describe the issue you encountered:
Similar to #3024, Windows should show a jump list

Expected behavior:
When Brave is pinned to the taskbar in Windows, you should be able to right click it and get a jump list of common actions, similar to what you do with other Windows apps

Here are some great docs with information about how we can do this (see User Tasks (Windows)):
http://electron.atom.io/docs/tutorial/desktop-environment-integration/

(should be as easy as making a few calls to the app.setUserTasks API)

For now, we might only be able to offer a "New window" option (since we don't have a concept of a private window yet).

Here's an example with a site pinned to taskbar from Internet Explorer (see the "Tasks" section)

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Windows

[cndouglas]

Related: #5141 (New Private Window in jump list)

[ShinyStar]

Hello!
I'd like to work on this issue and I have a few questions.
I've been looking at cmdLine.js and I haven't found any flags to open a new window from the command line. Am i missing it or should I add it?
And, if I did add it, would "--new-window" be ok as the flag? Should I make just one branch for both things, or one for adding the flag and another for the jump list?

[NumDeP]

+1 It's best to stick a feature/tor label on this as well so it can be arranged sooner.

[NumDeP]

@flamsmark don't you think it's a good idea to stick a feature/tor label on this issue and to additionally display something similar to the bottom inferences:

• New Window
• New A̶m̶n̶e̶s̶i̶a̶c̶ Private Window
• (̶T̶A̶B̶)̶ ̶T̶o̶r̶ ̶A̶m̶n̶e̶s̶i̶a̶c̶ ̶B̶r̶o̶w̶s̶i̶n̶g̶ New Private Tab with Tor

It will probably defeat the purpose for some users to insecurely open a new window and then toggle T̶A̶B̶ PTT afterwards if their intention is to T̶A̶B̶ PTT. Do you know what I mean?

[tildelowengrimm]

@NumDeP This feature doesn't depend on new Tor modes for implementation. When new Tor features are implemented, we can add them as additional options here and in the equivalent places for other docks/launchers. No reason to block this right now.

[bsclifton]

@NumDeP this feature doesn't have anything to do with Tor (although, having a new tor tab would be cool)

@ShinyStar I'd love to help you work on this 😄 The docs linked to in the original post should be enough to help get started. Please note: we use Muon, a fork of electron... but much of the code is the same 😄

Maybe start by getting a jump list showing and then we can go from there. The full chromium command line flags can be found here (although, we don't support all of them). Let me know if you have any more questions or if you want a review

[ShinyStar]

@bsclifton Thanks a lot for the help! I already have the jump list showing. As the post, said, its just a simple call to app.setUserTasks(). My problem is, however, getting it to open the new window because there isn't (or I haven't found) a way to open a new window by calling the program with arguments to do so. I thought I could implement that first and then apply it here, and I'm looking into it now. :)

[ShinyStar]

@bsclifton Hi! I did this to add the command line argument and jump list but since I'm calling Brave from the development environment it results in just Electron so I can't really test if the jump list works, I have only checked that the command line argument works by modifying npm start. How could I generate an installer to make sure that it really works?

[bsclifton]

@ShinyStar no need to generate an installer- you can create the packaged binaries and test using those 😄

From the command line, run npm run build-package. This will put the binaries into a folder like Brave-darwin-x64 (macOS) or similar on Windows. You should then be able to run the executable. Please make sure to use the --user-data-dir-name=brave-development argument if you want to use the same profile directory as regular development 😄

[bsclifton]

Closing as wontfix since we'll be moving away from Electron with the new Chromium UI that folks are working hard on (Brave Core).