Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Support dock menus #3024

Closed
bbondy opened this issue Aug 7, 2016 · 4 comments
Closed

Support dock menus #3024

bbondy opened this issue Aug 7, 2016 · 4 comments
Assignees
@NejcZdovc
Labels
OS/macOS QA/test-plan-specified release-notes/include shell-integration Integrating brave with OS-level UI features.
Milestone
0.13.0

Comments

@bbondy
Copy link
Member

bbondy commented Aug 7, 2016 •
edited
Loading

We should show at a minimum new window, new private window, and the list of windows there.
The list of windows would show the window title (i.e. active tab title)

Edit: Use app.dock.setMenu(menu)
@bbondy bbondy added the shell-integration Integrating brave with OS-level UI features. label Aug 7, 2016
@bbondy bbondy changed the title Support jump lists / tray menus Support jump lists / dock menus Aug 7, 2016
@bbondy
Copy link
Member Author

bbondy commented Aug 9, 2016

I think windows will show up just by using role: 'window' for macOS at least.

@bsclifton
Copy link
Member

Here's a great page for reference, for anyone wanting to tackle this 😄
http://electron.atom.io/docs/tutorial/desktop-environment-integration/

@bsclifton bsclifton added the help wanted The PR/issue opener needs help to complete/report the task. label Aug 11, 2016
@cndouglas cndouglas mentioned this issue Nov 18, 2016
Closed
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Dec 8, 2016
@NejcZdovc
Added dock menu for macOS
8b380a7 
Resolves brave#3024

Added doc menu for macOS with items:
- new window

Auditors: @bbondy, @bsclifton

Test Plan:
Open Brave on macOS. Right click on the icon in the dock. There should be a menu item named "New window". Clicking on it needs to open new Brave window
@NejcZdovc NejcZdovc mentioned this issue Dec 8, 2016
Merged
4 tasks
@bsclifton bsclifton changed the title Support jump lists / dock menus Support dock menus Dec 8, 2016
@bsclifton bsclifton mentioned this issue Dec 8, 2016
Closed
@bsclifton
Copy link
Member

Windows functionality broken out to #6094 since a PR was submitted for this (thanks, @NejcZdovc!)

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Dec 9, 2016
@NejcZdovc
Added dock menu for macOS
688aab1 
Resolves brave#3024

Added doc menu for macOS with items:
- new window

Auditors: @bbondy, @bsclifton

Test Plan:
Open Brave on macOS. Right click on the icon in the dock. There should be a menu item named "New window". Clicking on it should open new Brave window.
@luixxiul luixxiul added this to the 0.13.0 milestone Dec 9, 2016
This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
@NejcZdovc NejcZdovc self-assigned this Jan 11, 2017
@luixxiul
Copy link
Contributor

Test plan: #6087 (comment)

@luixxiul luixxiul added QA/test-plan-specified release-notes/include and removed help wanted The PR/issue opener needs help to complete/report the task. labels Jan 16, 2017
@cndouglas cndouglas mentioned this issue Jan 27, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
OS/macOS QA/test-plan-specified release-notes/include shell-integration Integrating brave with OS-level UI features.
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
4 participants
@bbondy @luixxiul @bsclifton @NejcZdovc