Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Pinning Brave to the taskbar on Windows 10 shows a generic document icon #5749

Closed
toolness opened this issue Nov 20, 2016 · 7 comments
Closed
Labels
needs-info Another team member needs information from the PR/issue opener. OS/Windows regression stale

Comments

@toolness
Copy link

Did you search for similar issues before submitting this one?

Yes. I found #786, but it's a closed issue, whereas I am still experiencing this problem. That issue also says that the proper icon isn't used while Brave is running, whereas I seem to be having the problem regardless of whether the app is running.

Describe the issue you encountered:

When Brave is unpinned from the taskbar, its icon looks fine, but as soon as I pin it, it becomes a standard "unknown document" icon like so:

taskbar-icon

Expected behavior:

  • Platform (Win7, 8, 10? macOS? Linux distro?):

Windows 10

  • Brave Version:

0.12.9

  • Steps to reproduce:

    1. Start Brave
    2. In the taskbar, right-click the Brave icon and choose "Pin to taskbar"
  • Any related issues:

While I appear to have the latest version of Brave, I first installed Brave a while ago--I forget when, but it might have been before #786 was fixed. I could try uninstalling and then re-installing Brave but I'm holding off on it unless I'm told to do otherwise.

@bsclifton
Copy link
Member

@toolness good eye, noticing #786; This issue should have been fixed with #1944

Can you please try un-pinning, closing Brave... re-launching Brave and then re-pinning please? Specifically, it has to do with the app name that was associated with what was pinned. Thanks 😄

@bsclifton bsclifton added needs-info Another team member needs information from the PR/issue opener. OS/Windows labels Nov 21, 2016
@toolness
Copy link
Author

Just tried that and unfortunately it doesn't seem to change things :( Any other ideas? I'm happy to debug from my end.

@bsclifton
Copy link
Member

I'm going to close this issue as there haven't been any recent reports. If we see this again, please reopen

@toolness if you still use Brave, please let me know if you still experience the issue? Thanks!

@LaurenWags
Copy link
Member

Reported via twitter: https://twitter.com/Phil_Wheeler/status/881826396636561409

I have requested user to try your suggestion here #5749 (comment) will update once I receive additional information.

cc: @bsclifton

@LaurenWags LaurenWags reopened this Jul 3, 2017
@kjozwiak
Copy link
Member

Is this still an issue? @toolness, have you ran into this with newer builds? I tried reproducing the issue with newer and older builds and couldn't reproduce it on Win 10 x64.

@LaurenWags have we received a lot of reports from the community regarding this issue in the past few months? If this affected all Windows installs, I think we would get a lot more reports from the community.

Brave 0.19.3 rev 053c863 - Couldn't reproduce
Muon 4.4.9
libchromiumcontent 60.0.3112.101

Brave 0.18.23 rev 36ae2ec - Couldn't reproduce
Muon 4.3.10
libchromiumcontent 60.0.3112.90

Test Cases Used:

  • pinning via the Desktop Icon -> Pin to taskbar
  • Pinning via Taskbar -> Pin to taskbar
  • Pinning via Start -> Search for Brave -> Right Click -> Pin to taskbar

I also attempted to go through the following:

  • Installed Brave 0.12.9 rev: 0d11443
  • Right clicked the Brave instance in the taskbar and selecting "Pin to taskbar"
  • Updated to Brave 0.18.23 rev 36ae2ec

@srirambv
Copy link
Collaborator

I haven't seen this in a long time. It happened only during one release(around 0.12.x) but never happened again

@LaurenWags
Copy link
Member

@kjozwiak no, I haven't seen a lot of reports of this in community, just received the one via twitter from my comment.

@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@bsclifton bsclifton added the stale label Aug 7, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Aug 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-info Another team member needs information from the PR/issue opener. OS/Windows regression stale
Projects
None yet
Development

No branches or pull requests

6 participants