Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

brave tries to save brave.exe when opened #6075

Closed
msieng opened this issue Dec 7, 2016 · 41 comments
Closed

brave tries to save brave.exe when opened #6075

msieng opened this issue Dec 7, 2016 · 41 comments
Assignees
@bsclifton
Labels
bug OS/Windows QA/checked-Win32 QA/checked-Win64
Milestone
0.12.15

Comments

@msieng
Copy link

msieng commented Dec 7, 2016

Did you search for similar issues before submitting this one?

Describe the issue you encountered:

Expected behavior:

  • Platform (Win7, 8, 10? macOS? Linux distro?):

  • Brave Version:

  • Steps to reproduce:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
@ghost
Copy link

ghost commented Dec 7, 2016

Facing the same problem with Win 8.1 Browser/Laptop 0.12.13 via Update.

@josiah-keller
Copy link
Contributor

josiah-keller commented Dec 8, 2016 •
edited
Loading

I can reliably reproduce this on Windows 10. On app launch, the first tab navigates to file:///C:/Users/Josiah/AppData/Local/brave/app-0.12.13/Brave.exe, which launches the Save As... dialog. However, this only occurs from my taskbar shortcut. Launching Brave from my Start tile opens the browser to the New Tab page as expected.

The taskbar shortcut points to: C:\Users\Josiah\AppData\Local\brave\Brave.exe --processStart "Brave.exe"

The start shortcut points to: C:\Users\Josiah\AppData\Local\brave\Update.exe --processStart "Brave.exe"

The taskbar shortcut lost its icon, too.

@msp1111111
Copy link

Same. Win 7 0.12.13. Also is making it so my preferences won't open and passwords (saved by Brave) won't load.

@luixxiul luixxiul added this to the 0.13.0 milestone Dec 8, 2016
@luixxiul luixxiul added the bug label Dec 8, 2016
@srirambv
Copy link
Collaborator

srirambv commented Dec 8, 2016

+1 from support

@mbretttx
Copy link

mbretttx commented Dec 8, 2016

Experiencing same on Windows 7 ver 6.1.7601. Brave ver 0.12.13. Brave does start & have not found any issues. I saved the brave.exe file and tried to run it which gave me the error 'The program can't start because node.dll is missing from your computer.

Did some quick research & found the following info:
We don't advise to download the node.dll file and copy it to the Windows system directory. The software's creators almost never circulate the DLL files, they are always part of an installation set. It's the installation set's task to perform the sufficient verifications before the installation. An incorrectly installed DLL file may cause the system's complete inability to function.
If you need a DLL file in spite of the above for the sake of restoring a system, then download it from a reliable source, possibly from the manufacturer's site.

@bsclifton
Copy link
Member

May or may not be related to #5749

@bsclifton
Copy link
Member

bsclifton commented Dec 8, 2016 •
edited
Loading

@mbretttx node.dll should already be included; if you were up for troubleshooting, I can help you with some next steps

Basically, you should be able to navigate to:
%userprofile%\AppData\Local\brave

From there, you'll see Update.exe. That's the executable that should be launching when you have Brave pinned (specifically, the pinned shortcut should be executing C:\Users\brian\AppData\Local\brave\Update.exe --processStart "Brave.exe" (except with your path of course)

Try opening the 0.12.13 folder and inspecting what's there. You should see both Brave.exe and node.dll (among other files). Let me know how that looks (here's a pic)

screen shot 2016-12-08 at 10 27 22 am

@josiah-keller josiah-keller mentioned this issue Dec 8, 2016
Closed
@takujun
Copy link

takujun commented Dec 8, 2016

I just found my file Brave.exe and BraveSetup-x64.exe. So I click on BraveSetup-x64 one, it came out good.
It is seems like fix it !

@msp1111111
Copy link

I had Brave pinned to my taskbar and clicking on that made this error happen. When I clicked on the desktop shortcut that Brave created when updating, it worked fine. I got rid of my taskbar shortcut and replaced it with the new one, now everything is OK. Not sure what the old pinned taskbar shortcut was pointing to.

@mbretttx
Copy link

mbretttx commented Dec 8, 2016

@bsclifton I looked at 0.12.13 as you suggested everything looked ok. However, when I opened the file location that my desktop shortcut was pointing to it was not the same. The file location did not contain app-0.12.13. It only had app-01.12.11 . I removed the pinned shortcut, then ran BraveSetup-x64 as suggested by @takujun. The problem went away, startup worked as it should. I then re-pinned the shortcut to the task bar, shutdown Brave and restarted it using the new pinned shortcut. There were no problems, everything worked as it should. Also, the new shortcut is now pointing to the correct set of files. Looks like running BraveSetup-x64 fixed the problem. So now that we have a fix, perhaps tech support might be able to figure out the cause, so that we don't have a re-occurrence in the future.

@ghost
Copy link

ghost commented Dec 9, 2016

Have been using the pinned taskbar Brave icon for the last few days without problem. Only just now, 8:34pm 8 Dec 16, on opening Brave tried to save a new copy of itself to the Downloads folder. Closed Brave, removed the pinned taskbar icon. Opening Brave from the Start menu works fine. Pinned this icon to the taskbar and closed Brave. The new pinned Brave taskbar icon works without problems. (Using Windows 10 64bit, Classic Start Menu, Brave 0.12.13).

@srirambv
Copy link
Collaborator

srirambv commented Dec 9, 2016

+1 from support

@srirambv
Copy link
Collaborator

srirambv commented Dec 9, 2016

I tried upgrading from 0.12.11 and 0.12.12 but cannot repro this. It always opens up the browser with no prompt to save.

@mbretttx
Copy link

mbretttx commented Dec 9, 2016

@srirambv It looks like everyone the problem was with 0.12.13, rather than 0.12.12. When I looked at my problem I found that my pinned shortcut was pointing to the files for 0.12.11 rather than 0.12.13. This was resolved by deleting the shortcut running the x64 exe and producing a new shortcut. In fact, during my process of troubleshooting, I found nothing on my system regarding 0.12.12.

@srirambv
Copy link
Collaborator

srirambv commented Dec 9, 2016

@mbretttx There were couple of reports stating after upgrade to 0.12.13 the issue started to happen hence I tried upgrading from the previous two version to see if it can be reproduced but with no luck.

+1 from support

@srirambv
Copy link
Collaborator

srirambv commented Dec 9, 2016

1 more from support

@jonathansampson
Copy link
Collaborator

I too am facing this on Windows 10, 14393.

@msieng
Copy link
Author

msieng commented Dec 11, 2016

It is related to the update. As soon as Brave updated, the pinned icon led to the file save. I deleted and repinned, problem solved.

@srirambv
Copy link
Collaborator

+1 from support

@srirambv
Copy link
Collaborator

More from support

https://linkbubble.zendesk.com/agent/tickets/7245
https://linkbubble.zendesk.com/agent/tickets/7242
https://linkbubble.zendesk.com/agent/tickets/7240
https://linkbubble.zendesk.com/agent/tickets/7234
https://linkbubble.zendesk.com/agent/tickets/7233

@luixxiul luixxiul mentioned this issue Dec 12, 2016
Closed
This was referenced Dec 12, 2016
Closed
Closed
@bsclifton
Copy link
Member

bsclifton commented Dec 12, 2016 •
edited
Loading

Issue opened in Squirrel repo:
Squirrel/Squirrel.Windows#900

Sorry for the inconvenience folks ☹️

@bsclifton
Copy link
Member

If you're really bored, here's an overview I just typed up about how the auto update process works:
https://github.com/brave/browser-laptop/wiki/How-auto-updates-for-Brave-work-on-Windows

We should be able to deliver a fix tomorrow! 😄 Hang in there please

@bbondy bbondy modified the milestones: 0.12.15, 0.13.0 Dec 13, 2016
@bbondy
Copy link
Member

bbondy commented Dec 13, 2016

moved to 0.12.15

@bbondy bbondy closed this as completed Dec 13, 2016
This was referenced Dec 13, 2016
Closed
Closed
Closed
Closed
@hockey97
Copy link

Yes, tried the fix and it works.

My shortcut / launcer target was Brave.exe.

I changed it to Update.exe by itself didn't work until I added --processStart "Brave.exe" with it and it now works perfectly can launch the browser as I normally would.

@bsclifton bsclifton mentioned this issue Dec 14, 2016
Closed
@bsclifton
Copy link
Member

+3 from folks here:
#6189

This was referenced Dec 14, 2016
Closed
Closed
@cndouglas
Copy link

@bsclifton: Does fa23dfb fix the problem? If not, should this issue be reopened for now?

@bsclifton
Copy link
Member

bsclifton commented Dec 14, 2016 •
edited
Loading

@liunkae actually, it's fixed by 701bd89 We'll be testing this morning 😄

BTW- I can't find a way to contact you, but you're more than welcome to join our community Slack. Send me an email at [email protected] if you're interested in an invite

@Jes4Kix
Copy link

Jes4Kix commented Dec 14, 2016

Keep up the great work! it's greatly appreciated and doesn't go unnoticed

@bsclifton
Copy link
Member

OK folks! If you can grab the latest update, the issue should be fixed 😄 Please let us know how it goes!

@Jes4Kix thank you 😄 It was not an easy one to pin down, but @aekeus and I did find it! Big thanks to @paulcbetts for the Squirrel fix

cc: @josiah-keller @msieng @icecoldsquirrel @jonathansampson @mbretttx @gabriel1313 @msp1111111 @oohjhu @gordonq @Skiiowa @bdukes, @Brendon-Coombes

@takujun
Copy link

takujun commented Dec 14, 2016 via email

@bsclifton
Copy link
Member

@takujun can you right click the shortcut that you use to launch Brave and pick "Properties"? I am curious what the target field looks like. For example, mine is like this:

screen shot 2016-12-14 at 2 46 42 pm

@takujun
Copy link

takujun commented Dec 14, 2016 via email

@takujun
Copy link

takujun commented Dec 14, 2016 via email

@josiah-keller
Copy link
Contributor

My taskbar shortcut got changed to C:\Users\Josiah\AppData\Local\brave\app.ico --processStart "Brave.exe" and I had to change it back to Update.exe. @bsclifton

@ChrisW001
Copy link

Since Brave doesn't have a real support section I can ask for help from, I had to go to that "Community" messageboard where they just kept telling me to unpin it from the taskbar and repin it. Since new users are limited in the number of comments they can make per day, I've already run out of times to say "I've been trying that for over twenty hours and it still hasn't worked."

Ok, I've changed "Brave.exe" to "Update.exe" on the shortcut. Now, instead of trying to save itself in the Download folder, a screen starts to open and fades away a split-second later. I've uninstalled it and reinstalled it, I've pinned and unpinned it from the taskbar. I am not happy with Brave right now, and it's taken me nearly a day to even get a response. Last night, I went to Internet Explorer and within 30 seconds, there was someone asking how they could help me.

@bsclifton
Copy link
Member

@ChrisW001 Apologies that Brave isn't working as intended. Please understand:

  • We have provided the best troubleshooting steps that we can. You've let us know loud and clear that they don't work. We appreciate that you tried the steps and reported back. This gives us more data

  • Brave is a work in progress and all of us are doing our best (there are only so many of us and only so many hours in a day)

Because you've had so much trouble, I'd recommend not using Brave yet. Use another browser for now and track issues you care about here on GitHub. When those issues are fixed, you can try it again and see if Brave is the right browser for you

@Skiiowa
Copy link

Skiiowa commented Jan 9, 2017 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
bug OS/Windows QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.15
Development

No branches or pull requests