This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
bookmarks toolbar is not displaying '>>' expansion, truncates titles instead #6767
Assignees
Labels
Milestone
Comments
NejcZdovc
pushed a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Jan 23, 2017
This was only a problem in production.
Minificaiton in CSS was causing problems with CSS variables and `getComputedStyle(document.querySelector(':root')).getPropertyValue('--bookmark-item-max-width')` returning non pixel values, which JS code expected it to be pixel values.
In particular it would only do this for any value that had more than 1
digit. It tried to use different unit types because it is less
characters. This would be fine if there were no css variables being
used in JS.
Auditors: @bsclifton
Fix brave#6767
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
After adding enough bookmarks, the toolbar should display an expansion icon '>>'. It truncated the last title instead.
Platform (Win7, 8, 10? macOS? Linux distro?):
Tested on OS X
Brave Version (revision SHA):
0.13.0 Preview 10 (c60b783)
Steps to reproduce:
Actual result:
The title of the rightmost bookmark is truncated.
Expected result:
An expansion icon should be displayed.
Will the steps above reproduce in a fresh profile? If not what other info can be added?
Yes, but requires user to create bookmarks.
Is this an issue in the currently released version?
Can this issue be consistently reproduced?
Extra QA steps:
1.
2.
3.
Screenshot if needed:
The text was updated successfully, but these errors were encountered: