Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Performance : 0.13.0 page load tracking issue #6836

Closed
alexwykoff opened this issue Jan 24, 2017 · 8 comments
Closed

Performance : 0.13.0 page load tracking issue #6836

alexwykoff opened this issue Jan 24, 2017 · 8 comments
Assignees
@alexwykoff
Labels
perf

Comments

@alexwykoff
Copy link
Contributor

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    page loads appear to be slower

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    all, primary testing on os x
    win coverage needed

  • Brave Version (revision SHA):
    0.13.0 rc5

  • Steps to reproduce:
    try this once with brave and once with chrome

Process 1. default shields, start timer, with one tab, open these sites in order :
a. facebook.com
b. wikipedia.org
c. amazon.com
d. twitter.com
e. qq.com
f. taobao.com
g. linkedin.com
h. outlook.com (log into site and load inbox)

Process 2. shields down, start timer, with one tab, open these sites in order :
a. facebook.com
b. wikipedia.org
c. amazon.com
d. twitter.com
e. qq.com
f. taobao.com
g. linkedin.com
h. outlook.com (log into site and load inbox)

  • Actual result:

  • Expected result:

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?

  • Is this an issue in the currently released version?

  • Can this issue be consistently reproduced?

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
@alexwykoff alexwykoff added this to the 0.13.0 milestone Jan 24, 2017
@alexwykoff
Copy link
Contributor Author

manual runs were somewhat inconclusive. only 0.13.0 rc5 with shields down was an outlier for poor performance

automation would certainly help so that we can track values over time

@alexwykoff
Copy link
Contributor Author

some sites which could stand to load faster :

alipay - #3603
qq.com
taobao.com

@bbondy
Copy link
Member

bbondy commented Jan 25, 2017 •
edited
Loading

I did some improvements here but I want to do more, so I'll leave this open.
Work done so far:
95ade41
6f9682a
e198468
6423cea

@bbondy
Copy link
Member

bbondy commented Jan 25, 2017

moving to next milestone since no more work will be done for this one, too risky

@bbondy bbondy modified the milestones: 0.13.1, 0.13.0 Jan 25, 2017
@luixxiul
Copy link
Contributor

I added release-notes/include as this issue will be fixed in the next milestone.

bbondy added a commit that referenced this issue Jan 29, 2017
@bbondy
Various speedups around page load
6423cea 
Removes various sync IPC calls around page load

Part of #6836

Auditors: @bridiver
@luixxiul luixxiul modified the milestones: 0.13.3, 0.13.2 Feb 1, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Feb 1, 2017

the milestone was reset to 0.13.3

@bbondy bbondy modified the milestones: 0.13.5, 0.13.6 Feb 15, 2017
@luixxiul luixxiul added this to the 0.16.200 milestone May 28, 2017
@luixxiul luixxiul added needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. and removed release-notes/include labels May 28, 2017
@bsclifton bsclifton mentioned this issue Jun 13, 2017
Closed
35 tasks
@alexwykoff alexwykoff removed this from the 0.18.x (Developer Channel) milestone Jun 23, 2017
@alexwykoff
Copy link
Contributor Author

Needs breakdown to more discrete issues.

@alexwykoff alexwykoff assigned alexwykoff and unassigned bbondy Jun 23, 2017
@alexwykoff
Copy link
Contributor Author

all of the prior mentioned PRs have landed, this was only staying open as a string-on-finger reminder of automation work to be done re: page perf.

@luixxiul luixxiul removed the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Oct 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexwykoff alexwykoff

Labels
perf
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bbondy @alexwykoff @luixxiul