Fixed Spotify no longer playing music

[echosa]

Original title: Spotify no longer plays music #6881 (comment)

Test Plan

1. Open a new tab and go to spotify.com
2. Try using the player.
3. Make sure the Widevine popup is shown.

Original issue description

• Did you search for similar issues before submitting this one?

Yes

• Describe the issue you encountered:

Spotify is no longer working. When I go to the web player, it get an error. See screenshot.

There are JS errors. I'll attach a second screenshot showing them.

• Platform (Win7, 8, 10? macOS? Linux distro?):

OS X 10.11.6

• Brave Version (revision SHA):

0.12.15 and 0.13.0

• Steps to reproduce:

  1. Go to play.spotify.com
  2. Login to Spotify
  3. You'll be redirected to open.spotify.com
  4. You should see the error in the screenshot below and songs will not play. You should also see the JS errors in the console.

• Actual result:

Songs don't play. Error is displayed.

• Expected result:

Songs should play without error.

• Will the steps above reproduce in a fresh profile? If not what other info can be added?

Yes

• Is this an issue in the currently released version?

Yes

• Can this issue be consistently reproduced?

Yes

• Screenshot if needed:

[echosa]

The multiple NO_TRACK_PLAYER errors are there because I clicked "play" multiple times. Each click of "play" results in another error.

[cndouglas]

Any difference turning off some of the shield settings?

[echosa]

No different with shields off. In fact, I'd already turned shields off before reloading that taking those screenshots. I forgot to mention that in the initial issue. Sorry about that.

[cndouglas]

Please try again with version 0.13.0 now that it's out.

[echosa]

Not fixed. Still happening in 0.13.0.

[starkos]

FWIW, this is happening in Musicality too. The Spotify redesign seems to be looking for something Chrome specific, and getting unhappy when it can't find it. Not sure what it is yet though…

[starkos]

Okay, I found the source of the error, though I'm not sure how to fix it. This code in web-player.js:

n = {
                initDataType: void 0,
                audioCapabilities: [{
                    contentType: 'audio/mp4; codecs="mp4a.40.2"',
                    robustness: ""
                }],
                distinctiveIdentifier: "optional",
                persistenceState: "optional",
                sessionTypes: ["temporary"]
            };

return t.navigator.requestMediaKeySystemAccess("com.widevine.alpha", [n]).then(function(e) {
                return e.createMediaKeys()
            }).then(function(t) {
                return e._mediaKeys = t,
                e._player.setMediaKeys(t)
            }).then(function() {
                return e._trySetServerCertificate()
            });

…works in Chrome, but throws a DOMException "Unsupported keySystem" in Electron.

Electron does provide a way to use Chrome's WideVine plugin. But when I tried this, the Spotify code continued to throw the same exception, even though running the code in the Devtools Console worked fine. Not sure what's going on there.

[luixxiul]

@starkos Brave has the option to enable Widevine on about:preferences#security. Would you please try with the option enabled?

[starkos]

I don't have access to the redesign myself, I was given access to someone's machine via a screen share to try and figure it out. Not sure when I'll get the chance to try again, but I'm hoping to send them a WideVine-enable build (via the Electron command-line options) shortly.

@echosa, can you give it a try?

[echosa]

Spotify works with Widevine enabled! Even with shields up! <3

[luixxiul]

@diracdeltas Is it possible to display Widevine control dialog on Spotify automatically as we do on Netflix?

[cndouglas]

@luixxiul We need to add Spotify here.

[diracdeltas]

cc @bbondy on adding widevine

[bbondy]

should be straightforward to add for 0.13.6, I'll check.

[bsclifton]

Moving to 0.13.7

[bsclifton]

Moving to 0.14.3... @bbondy I know you added the Amazon check- please feel free to pull this back in if you have a solution 😄

[cndouglas]

PR: #8111 Note: The PR is a possible solution, and I did not verify if it works.

[bbondy]

Moved back to 0.14.2 since there's not much risk here and alex tried the PR and confirmed fixed.

[alexwykoff]

I wasn't prompted for the Widevine player but it worked anyway.

[srirambv]

Shows the prompt immediately on visit similar to Netflix