Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add Widevine for Spotify #8111

Merged
merged 1 commit into from
Apr 13, 2017
Merged

Add Widevine for Spotify #8111

merged 1 commit into from
Apr 13, 2017

Conversation

cndouglas
Copy link

@cndouglas cndouglas commented Apr 7, 2017 •
edited by bsclifton
Loading

Test Plan

  1. Open a new tab and go to spotify.com
  2. Try using the player.
  3. Make sure the Widevine popup is shown.

Description

Fixes #6881

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

@cndouglas cndouglas added this to the 0.14.3 milestone Apr 7, 2017
@cndouglas cndouglas self-assigned this Apr 7, 2017
@cndouglas cndouglas mentioned this pull request Apr 7, 2017
Closed
@alexwykoff
Copy link
Contributor

Works as expected for OS X.
Windows test underway, will update.

@bbondy
Copy link
Member

bbondy commented Apr 13, 2017

++

@bbondy bbondy merged commit adf4d9a into brave:master Apr 13, 2017
bbondy added a commit that referenced this pull request Apr 13, 2017
@bbondy
Merge pull request #8111 from Liunkae/widevine-spotify
c97265a 
Add Widevine for Spotify
@bsclifton bsclifton modified the milestones: 0.14.2, 0.14.3 Apr 13, 2017
@cndouglas cndouglas deleted the widevine-spotify branch April 17, 2017 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexwykoff alexwykoff Awaiting requested review from alexwykoff

Assignees

@cndouglas cndouglas

Labels
plugin/widevine QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cndouglas @alexwykoff @bbondy @bsclifton