Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Deleting bookmark removes pinned item #7283

Closed
srirambv opened this issue Feb 16, 2017 · 0 comments · Fixed by #7286
Closed

Deleting bookmark removes pinned item #7283

srirambv opened this issue Feb 16, 2017 · 0 comments · Fixed by #7286
Assignees
@darkdh
Labels
bug feature/bookmarks feature/pinned-tabs QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.5

Comments

@srirambv
Copy link
Collaborator

srirambv commented Feb 16, 2017 •
edited by luixxiul
Loading

Test plan

#7286 (comment)

  • Describe the issue you encountered:
    Deleting bookmark removes pinned item

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave : 0.13.5
    rev: 59a41eb

  • Steps to reproduce:

    1. Visit a site and add it as a bookmark
    2. Open the bookmarked site in a new tab/ open it from about:bookmarks
    3. Pin the new tab in which the bookmarked site is opened
    4. Delete the bookmark from about:bookmarks/bookmarks toolbar, pinned tab also gets removed

  • Actual result:
    Pinned tab is removed when the bookmark is deleted

  • Expected result:
    Only bookmark must be removed not the pinned tab itself

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes, Issue from 0.13.2 onwards. No such issue on 0.13.1

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    disappear

  • Any related issues:
    Pinned Tab and Bookmark Disappear after Deleting History #7238
    cc: @darkdh @bsclifton
@srirambv srirambv added this to the 0.13.5 milestone Feb 16, 2017
@darkdh darkdh self-assigned this Feb 16, 2017
darkdh added a commit to darkdh/browser-laptop that referenced this issue Feb 16, 2017
@darkdh
Only remove bookmark tag when it's pinned
7ba5c36 
filterOutNonRecents will do the cleanup

fix brave#7283

Auditors: @bbondy

Test Plan:
Covered by automatic test
@darkdh darkdh mentioned this issue Feb 16, 2017
Merged
4 tasks
darkdh added a commit to darkdh/browser-laptop that referenced this issue Feb 16, 2017
@darkdh
Only remove bookmark tag when it's pinned
576b66a 
filterOutNonRecents will do the cleanup

fix brave#7283

Auditors: @bbondy

Test Plan:
Covered by automatic test
@alexwykoff alexwykoff mentioned this issue Feb 26, 2017
Closed
This was referenced Mar 1, 2017
Closed
Closed
Closed
Closed
This was referenced Mar 3, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
bug feature/bookmarks feature/pinned-tabs QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.5
Development

Successfully merging a pull request may close this issue.

Only remove bookmark tag when it's pinned darkdh/browser-laptop
4 participants
@alexwykoff @luixxiul @darkdh @srirambv