Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Pinned Tab and Bookmark Disappear after Deleting History #7238

Closed
srirambv opened this issue Feb 14, 2017 · 0 comments · Fixed by #7239
Closed

Pinned Tab and Bookmark Disappear after Deleting History #7238

srirambv opened this issue Feb 14, 2017 · 0 comments · Fixed by #7239

Comments

@srirambv
Copy link
Collaborator

Reported on Win 8.1
Verified on Windows 10 x64

  • Brave Version (revision SHA):
    Brave: 0.13.2
    rev: 25b1199

  • Step to reproduce (Pin Tab):
    1.Visit site (e.g. http://kateglo.com)
    2.Pin tab
    3.Go to History
    4.Delete Kateglo from History entry

  • Step to reproduce (Bookmark):
    1.Visit site (e.g. http://kateglo.com)
    2.Bookmark it
    3.Go to History
    4.Delete Kateglo from History entry

  • Actual result:
    Bookmark and pinned tab is removed when specific history entry is deleted.

  • Expected result:
    Should retain bookmark/pinned tab when that page history is deleted

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Only on 0.13.2 and 0.13.3.
    Works fine on 0.13.1

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    image
    image

  • Any related issues:

@srirambv srirambv added this to the 0.13.3 milestone Feb 14, 2017
@darkdh darkdh self-assigned this Feb 14, 2017
darkdh added a commit to darkdh/browser-laptop that referenced this issue Feb 14, 2017
fix brave#7238

Auditors: @bsclfton, @bbondy

Test Plan:
Covered by automatic test
@darkdh darkdh mentioned this issue Aug 3, 2017
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.