Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tab preview on hover doesn't work after closing tab until moving the mouse out of tabs bar #7606

Closed
srirambv opened this issue Mar 8, 2017 · 3 comments · Fixed by #8902
Closed

Comments

@srirambv
Copy link
Collaborator

srirambv commented Mar 8, 2017

Test plan

See #8902

Original issue description

  • Did you search for similar issues before submitting this one?

  • Describe the issue you encountered:

  • Platform (Win7, 8, 10? macOS? Linux distro?):

  • Brave Version (revision SHA):

  • Steps to reproduce:
    1.
    2.
    3.

  • Actual result:

  • Expected result:

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?

  • Is this an issue in the currently released version?

  • Can this issue be consistently reproduced?

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:

@srirambv srirambv added this to the Backlog milestone Mar 8, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Mar 9, 2017

I noticed it as well, CC @NejcZdovc for thoughts

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Mar 9, 2017

@luixxiul problem is that mouse event is not triggered when component update is done. We have two options:

  • we add additional event mouseOver which will trigger preview as soon as you move mouse for a pixel (you don't need to move outside the tab bar, but you need to move mouse) - quick solution, but you still need to move mouse for 1 px
  • we add a function that will be triggered when component updates and will check where is the pointer and if pointer is inside the component we manually trigger preview (you don't need to move mouse) - not a quick solution, but address the problem 100%

cc @bsclifton

@bbondy
Copy link
Member

bbondy commented Mar 12, 2017

I think when a tab closes this might fire:
https://github.com/brave/browser-laptop/blob/master/js/stores/windowStore.js#L384
Making it clear the preview frame key. I think we should just be smarter about what to show IF there is already a preview frame.

@bsclifton bsclifton changed the title Tab hover dosnt work after closing tab until moving the mouse out of tabs bar Tab preview on hover doesn't work after closing tab until moving the mouse out of tabs bar Mar 16, 2017
@bsclifton bsclifton added feature/tabsbar needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. and removed needs-triage labels Mar 16, 2017
@cezaraugusto cezaraugusto self-assigned this May 2, 2017
@cezaraugusto cezaraugusto modified the milestones: 0.15.2, Backlog May 2, 2017
@alexwykoff alexwykoff modified the milestones: 0.15.4, 0.15.3 May 5, 2017
cezaraugusto added a commit that referenced this issue May 17, 2017
@luixxiul luixxiul added the bug label May 17, 2017
cezaraugusto added a commit that referenced this issue May 18, 2017
cezaraugusto added a commit that referenced this issue May 26, 2017
@bsclifton bsclifton removed the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Jun 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.