Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Trigger tab preview based on frame key #8902

Merged
merged 1 commit into from
Jun 2, 2017
Merged

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented May 17, 2017

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

When next tab exists

Static ordering

  1. Open 3 tabs with different websites
  2. Make first active
  3. Hover over second
  4. Close it
  5. Third tab (now second) should show as a preview

dynamic ordering

  1. Open 3 tabs with different websites
  2. Ensure you reorder tabs by drag-n-drop
  3. Make first active
  4. Hover over second
  5. Close it
  6. Third tab (now second) should show as a preview

when previous frame is not active

  1. Open 5 tabs
  2. Make third active
  3. Hover over fourth
  4. Close it
  5. Fifth tab (now fourth) should show as a preview

when next tab is null

  1. Open 3 tabs with different websites
  2. Close the 3rd tab
  3. no preview is triggered

when frame is closed by close tab shortcut

  1. Open 3 tabs with different websites
  2. Make first active
  3. Close it by shortcut (cmd/ctrl+w)
  4. No preview is triggered

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@cezaraugusto cezaraugusto added this to the 0.15.400 milestone May 17, 2017
@cezaraugusto cezaraugusto self-assigned this May 17, 2017
Copy link
Contributor

@luixxiul luixxiul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test plan works.

@cezaraugusto
Copy link
Contributor Author

works as-is but a new state is needed from #8852 so setting as blocked until that is approved

@bbondy
Copy link
Member

bbondy commented May 26, 2017

Pls rebase and remove the needs rebase tag when done. Thanks.

@cezaraugusto
Copy link
Contributor Author

rebased, removed PR/blocked tag as well I'll rework #8852 if needed, if this is approved first

Copy link
Contributor

@luixxiul luixxiul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test plans work.

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change works great! 😄

If you had time available, it would be awesome to have a test to make sure this behavior doesn't accidentally regress

@bsclifton bsclifton merged commit 7118d39 into master Jun 2, 2017
@bsclifton bsclifton deleted the tabsbar/close-n-preview branch June 2, 2017 22:49
bsclifton added a commit that referenced this pull request Jun 2, 2017
Trigger tab preview based on frame key
cezaraugusto added a commit that referenced this pull request Jun 17, 2017
cezaraugusto added a commit that referenced this pull request Jun 17, 2017
cezaraugusto added a commit that referenced this pull request Jun 17, 2017
cezaraugusto added a commit that referenced this pull request Jun 18, 2017
@luixxiul
Copy link
Contributor

Is this change covered with automated tests?

@cezaraugusto
Copy link
Contributor Author

@luixxiul I didn't include new ones but they are covered with existing tests for tab previews

@luixxiul
Copy link
Contributor

@cezaraugusto the question occurred to me because of the issue here: #10103

@cezaraugusto
Copy link
Contributor Author

ok np, that's related thanks for opening

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab preview on hover doesn't work after closing tab until moving the mouse out of tabs bar
4 participants