Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor widevinePanel.js and widevineInfo.js with Aphrodite and commonForm #8028

Closed
luixxiul opened this issue Apr 1, 2017 · 4 comments
Closed

Refactor widevinePanel.js and widevineInfo.js with Aphrodite and commonForm #8028

luixxiul opened this issue Apr 1, 2017 · 4 comments
Assignees
@luixxiul
Labels
plugin/widevine QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite refactoring release-notes/exclude
Milestone
0.15.300 (Frozen,...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Apr 1, 2017 •
edited
Loading

Test plan

#8032 (comment)

Describe the issue you encountered:
Refactor widevinePanel.js and widevineInfo.js with Aphrodite and commonForm

screenshot 2017-04-01 15 34 44

screenshot 2017-04-01 15 43 40
@luixxiul luixxiul self-assigned this Apr 1, 2017
@luixxiul luixxiul mentioned this issue Apr 1, 2017
Merged
4 tasks
@luixxiul luixxiul added this to the 0.14.3 milestone Apr 10, 2017
cezaraugusto pushed a commit that referenced this issue Apr 17, 2017
@luixxiul @cezaraugusto
Refactor widevinePanel.js and widevineInfo.js (#8032)
c1894b1 
Closes #8028
Addresses #7989

- Removed isClickDismiss from the dialog
  Installing Widevine influences globally, not specific to a tab which opens the page which requires Widevine. Removing isClickDismiss would clarify to the users that the third party software which we discourage from using is going to be installed on the browser right now.

- Applied commonForm.js to them in order to make styling consistent
- Added CommonFormLarge to commonForm.js
- Added globalStyles.dialogWidth and globalStyles.LargeWidth to global.js
- Added noMargin and noPadding to commonStyles.js
- Added margin-top to the bottom text block on widevineInfo.js
- Added testIds to the buttons and the dialog, modifying dialog.js
  - data-test-id as testId
  - data-test2-id as test2Id
- Added widevinePanelDialog as a testId
- Set cursor:pointer

Auditors:

Test Plan:
1. Visit netflix.com
2. Click outside of the dialog
3. Make sure the dialog is not closed
4. Click "Install and Allow"
5. Log in to the account
6. Make sure movies can be played
@cezaraugusto
Copy link
Contributor

closed by c1894b1

@luixxiul
Copy link
Contributor Author

luixxiul commented Apr 18, 2017 •
edited
Loading

May I reopen this, as this is not ready yet on master (it was merged to refactor-aphrodite, which I should have named better) and I have set to close this automatically when it is merged to master with a new PR, after every PR I have created which is related to commonForm is merged to refactor-aphrodite. I'm taking care of every issue which I assinged myself, thanks!

@luixxiul luixxiul reopened this Apr 18, 2017
@luixxiul
Copy link
Contributor Author

FYI there are 4 other PRs under WIP/ready-for-review before I am going to create that PR at last.

This was referenced May 2, 2017
Closed
Closed
Closed
Closed
@luixxiul
Copy link
Contributor Author

luixxiul commented May 3, 2017

note: widevine plugin is not available for linux distros

@alexwykoff alexwykoff mentioned this issue May 5, 2017
Closed
40 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
plugin/widevine QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite refactoring release-notes/exclude
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

No branches or pull requests
5 participants
@bbondy @alexwykoff @luixxiul @cezaraugusto @srirambv