This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Refactor widevinePanel.js and widevineInfo.js #8032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luixxiul
added
PR/work-in-progress ⚒
PR/needs-QA-attention ☕
and removed
PR/blocked
PR/work-in-progress ⚒
labels
cezaraugusto
suggested changes
Apr 16, 2017
| return <Dialog onHide={this.props.onHide} testId='widevinePanelDialog'> | ||
| <CommonFormLarge onClick={(e) => e.stopPropagation()}> | ||
| <CommonFormTitle data-l10n-id='widevinePanelTitle' /> | ||
| <WidevineInfo newFrameAction={windowActions.newFrame} /> |
There was a problem hiding this comment.
pls change it to
<WidevineInfo createTabRequestedAction={appActions.createTabRequested} />newFrameAction doesn't exist anymore and that makes info icon uncklicable
There was a problem hiding this comment.
Closes #8028 Addresses #7989 - Removed isClickDismiss from the dialog Installing Widevine influences globally, not specific to a tab which opens the page which requires Widevine. Removing isClickDismiss would clarify to the users that the third party software which we discourage from using is going to be installed on the browser right now. - Applied commonForm.js to them in order to make styling consistent - Added CommonFormLarge to commonForm.js - Added globalStyles.dialogWidth and globalStyles.LargeWidth to global.js - Added noMargin and noPadding to commonStyles.js - Added margin-top to the bottom text block on widevineInfo.js - Added testIds to the buttons and the dialog, modifying dialog.js - data-test-id as testId - data-test2-id as test2Id - Added widevinePanelDialog as a testId - Set cursor:pointer Auditors: Test Plan: 1. Visit netflix.com 2. Click outside of the dialog 3. Make sure the dialog is not closed 4. Click "Install and Allow" 5. Log in to the account 6. Make sure movies can be played
|
@cezaraugusto ready for re-review :-) |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor widevinePanel.js and widevineInfo.js
Closes #8028
Addresses #7989
Installing Widevine influences globally, not specific to a tab which opens the page which requires Widevine. Removing isClickDismiss would clarify to the users that the third party software which we discourage from using is going to be installed on the browser right now.
Auditors:
Test Plan:
git rebase -ito squash commits (if needed).Test Plan: