Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tab update events happen when there are no tab updates #9313

Closed
bbondy opened this issue Jun 7, 2017 · 2 comments
Closed

Tab update events happen when there are no tab updates #9313

bbondy opened this issue Jun 7, 2017 · 2 comments
Labels
bug perf QA/test-plan-required release-notes/include
Milestone
0.16.x (Frozen, o...

Comments

@bbondy
Copy link
Member

bbondy commented Jun 7, 2017 •
edited
Loading

Because of an equality check that always differs for deep objects, we were wrongly thinking there were tab updates causing an event storm if the user had a lot of tabs.

The fix is actually in muon but I'm tracking here.
@bbondy bbondy added this to the 0.17.x (Frozen, only critical adds from here) milestone Jun 7, 2017
bbondy added a commit to brave/muon that referenced this issue Jun 7, 2017
@bbondy
Tab update events should only fire when data has changed
58f78f0 
Fix brave/browser-laptop#9313
@bbondy bbondy mentioned this issue Jun 7, 2017
Merged
bridiver pushed a commit to brave/muon that referenced this issue Jun 7, 2017
@bbondy @bridiver
Tab update events should only fire when data has changed
6a3e128 
Fix brave/browser-laptop#9313
@ayumi ayumi mentioned this issue Jun 7, 2017
Closed
35 tasks
@luixxiul luixxiul added bug needs-info Another team member needs information from the PR/issue opener. perf release-notes/include QA/test-plan-required and removed needs-info Another team member needs information from the PR/issue opener. labels Jun 8, 2017
@bsclifton
Copy link
Member

@bbondy @bridiver @ayumi was this fixed in Muon 4.0.1? If so, we can bump milestone to 0.16.x

@bbondy bbondy modified the milestones: 0.16.x (Frozen, only critical adds from here), 0.17.x (Frozen, only critical adds from here) Jun 8, 2017
@bbondy
Copy link
Member Author

bbondy commented Jun 8, 2017

Yes it is in 4.0.1 and we want to upgrade to that for the next RC. Moving this to 0.16.x

@bbondy bbondy mentioned this issue Jun 8, 2017
Closed
4 tasks
hferreiro pushed a commit to brave/muon that referenced this issue Jun 29, 2017
@bbondy @hferreiro
Tab update events should only fire when data has changed
c3429ce 
Fix brave/browser-laptop#9313
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug perf QA/test-plan-required release-notes/include
Projects
None yet
Milestone
0.16.x (Frozen, only critical adds fr...
Development

No branches or pull requests
3 participants
@bbondy @luixxiul @bsclifton