This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix deleting history entry #10069
Merged
Fix deleting history entry #10069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
reviewed
Aug 3, 2017
js/state/siteUtil.js
Outdated
| @@ -417,6 +417,10 @@ module.exports.removeSite = function (state, siteDetail, tag, reorder = true, sy | |||
| site = site.set('tags', tags) | |||
| return state.setIn(stateKey, site) | |||
| } else { | |||
| if (!tag && module.exports.isHistoryEntry(siteDetail)) { | |||
| // Delete the site from history | |||
| return state.deleteIn(stateKey) | |||
fix #8761 test plan: 1. open a new tab, go to some site 2. close the tab 3. open about:history. right-click to delete the site. it should disappear from the list 4. open the History menu. you should no longer see the site under 'Recently Closed'. 5. repeat above steps but opening/closing two tabs and selecting both of them to delete instead of only one
diracdeltas
force-pushed
the
fix/delete-history
branch
from
ef785e4
to
67aef34
Compare
|
@darkdh good catch, i think it's fixed now |
Codecov Report
@@ Coverage Diff @@
## master #10069 +/- ##
==========================================
- Coverage 52.95% 52.93% -0.02%
==========================================
Files 228 228
Lines 20308 20327 +19
Branches 3253 3258 +5
==========================================
+ Hits 10754 10761 +7
- Misses 9554 9566 +12
|
|
Merging. need to make sure this works after #10296 |
|
I added |
|
@luixxiul was this actually reverted? Per @diracdeltas comment above, should the two issues she mentioned be reopened? |
|
I think I misunderstood something. please ignore #10069 (comment). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8761
test plan:
I tried to write a test for this but couldn't find a way to get Webdriver to click on a context menu item in about:history.
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests