This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Add FlyoutDialog and polish CommonForm #10978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luixxiul
added
priority/P4
luixxiul
added
help wanted
8 tasks
luixxiul
added
PR/work-in-progress ⚒
and removed
help wanted
Codecov Report
@@ Coverage Diff @@
## master #10978 +/- ##
==========================================
+ Coverage 53.15% 53.19% +0.03%
==========================================
Files 274 275 +1
Lines 25996 25993 -3
Branches 4149 4154 +5
==========================================
+ Hits 13818 13826 +8
+ Misses 12178 12167 -11
|
luixxiul
commented
Sep 19, 2017
test/misc-components/syncTest.js
Outdated
| @@ -616,8 +616,7 @@ describe('Syncing bookmarks from an existing profile', function () { | |||
| const folder = `[data-test-id="bookmarkToolbarButton"][title="${folderTitle}"]` | |||
| yield Brave.app.client | |||
| .waitForVisible(folder) | |||
| .click(folder) | |||
| .click(folder) | |||
| .doubleClick(folder) | |||
There was a problem hiding this comment.
This change lets the test passed locally, while the test fails on Travis:
https://travis-ci.org/brave/browser-laptop/jobs/277154849#L3775
1) Syncing bookmarks from an existing profile update bookmark, moving it into the folder:
Error: element (".contextMenu") still not visible after 10000ms
at elements(".contextMenu") - isVisible.js:54:17
at isVisible(".contextMenu") - waitForVisible.js:73:22
npm run test -- --grep='Syncing bookmarks from an existing profile update bookmark, moving it into the folder'
There was a problem hiding this comment.
@cezaraugusto @bsclifton would you mind helping me to fix the issue? thanks!
There was a problem hiding this comment.
for me they are all failing. I just did a rebase + push let's see how it goes
There was a problem hiding this comment.
It looks the sync tests fail on master as well.
8 tasks
ghost
removed
the
priority/P5
|
|
| this.props.small && styles.commonForm_small, | ||
| this.props.medium && styles.commonForm_medium, | ||
| this.props.large && styles.commonForm_large, | ||
| this.props.custom |
There was a problem hiding this comment.
in a follow-up: these could be described in about styles too
There was a problem hiding this comment.
Agreed. I'll add some comment to about:styles#commonForm in the follow up
-> Done with https://github.com/brave/browser-laptop/pull/11522/files#diff-423dee85eaa4c9b5825e4a8a25794922R29 on #11522
8 tasks
bbondy
modified the milestones:
0.21.x (Developer Channel),
0.20.x (Beta Channel),
Backlog
luixxiul
added
QA/test-plan-specified
and removed
help wanted
syuan100
pushed a commit
to syuan100/browser-laptop
that referenced
this pull request
Nov 9, 2017
Follow-up to brave#10978 (comment) Auditors: @cezaraugusto Test Plan: 1. Open about:styles
added 2 commits
November 13, 2017 17:38
- Update commonForm components based on FlyoutDialog Addresses #7114 Closes #10977 Auditors: @cezaraugusto @bsclifton Test Plan 1. Open about:styles 2. Click `commonForms` 3. Make sure the common form dialog is properly styled
- Replace FlyoutDialog with CommonForm to dismiss the possibility of visual regression - Reduce components by adding props - Add 'CommonFormSection title' to bookmark hanger - Update to the modified BEM style - Fix data-test-id Auditors: Test Plan: 1. Open about:styles 2. Click 'commonForm' 3. Make sure the common form panel is properly displayed
cezaraugusto
approved these changes
Nov 21, 2017
cezaraugusto
added
0.22.x
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #7114
Closes #10977
Auditors: @cezaraugusto @bsclifton
Test Plan
commonFormsSubmitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests