Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Revert Aphrodite changes that were breaking bookmark modals #14162

Merged
merged 1 commit into from
May 17, 2018
Merged

Revert Aphrodite changes that were breaking bookmark modals #14162

merged 1 commit into from
May 17, 2018

Conversation

bsclifton
Copy link
Member

Fixes #12498
Unfixes #10977

Auditors: @NejcZdovc, @cezaraugusto

Revert "Polish CommonForm"
This reverts commit c5186d5.

Revert "Add FlyoutDialog"
This reverts commit 32dca6f.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

N/A - this removes the feature

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Fixes #12498
Unfixes #10977

Auditors: @NejcZdovc, @cezaraugusto

Revert "Polish CommonForm"
This reverts commit c5186d5.

Revert "Add FlyoutDialog"
This reverts commit 32dca6f.
@bsclifton bsclifton added this to the 0.23.x (Developer Channel) milestone May 17, 2018
@bsclifton bsclifton self-assigned this May 17, 2018
@bsclifton
Copy link
Member Author

Changes originally introduced with #10978 (has not been released yet)

Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit 027fbd7 into brave:master May 17, 2018
cezaraugusto added a commit that referenced this pull request May 17, 2018
Revert Aphrodite changes that were breaking bookmark modals
@cezaraugusto
Copy link
Contributor

master (0.24.x) 027fbd7
0.23.x ef75387

@bsclifton bsclifton deleted the revert-aphrodite-dialog-changes branch May 17, 2018 19:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bookmarks Toolbar Dialog is closing incorrectly (maybe check some other dialogs too...)
2 participants