Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Jump list added #13193

Closed
wants to merge 2 commits into from
Closed

Jump list added #13193

wants to merge 2 commits into from

Conversation

ShinyStar
Copy link

Added the functionality to show a jump list on Windows and open a new window from there.
Resolves #6094, in which I'm working on with @bsclifton's help, and depends on pull request #13192

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests). (Does this require tests?)
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  • Open Brave and right-click the task bar icon to show the jump list.
  • There will be an option to open a new window, click it and a new window will open.

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@codecov-io
Copy link

codecov-io commented Feb 19, 2018

Codecov Report

Merging #13193 into master will decrease coverage by 0.05%.
The diff coverage is 13.33%.

@@            Coverage Diff             @@
##           master   #13193      +/-   ##
==========================================
- Coverage   56.27%   56.21%   -0.06%     
==========================================
  Files         282      282              
  Lines       28027    28042      +15     
  Branches     4584     4589       +5     
==========================================
- Hits        15772    15765       -7     
- Misses      12255    12277      +22
Flag Coverage Δ
#unittest 56.21% <13.33%> (-0.06%) ⬇️
Impacted Files Coverage Δ
app/cmdLine.js 36.13% <13.33%> (-3.29%) ⬇️
js/stores/appStoreRenderer.js 91.66% <0%> (-8.34%) ⬇️
app/renderer/components/reduxComponent.js 57.75% <0%> (-3.45%) ⬇️
js/stores/windowStore.js 27.65% <0%> (-0.3%) ⬇️

@bsclifton bsclifton added this to the 0.23.x (Nightly Channel) milestone Feb 20, 2018
@bsclifton bsclifton modified the milestones: 0.23.x (Nightly Channel), 0.24.x Feb 26, 2018
@bsclifton bsclifton removed this from the Completed work milestone Jul 13, 2018
@bsclifton
Copy link
Member

Apologies that we never got a chance to review this ☹️

We're in the middle of moving from our Muon codebase over to a fork of the Chromium UI (Brave Core). We should get all of the functionality present in Chromium and will no longer have any ties to Electron at that point.

I'm going to close this PR and the accompanying issues/PRs, but I definitely appreciate the time you put towards this 😄 If you wanted to check out the new codebase, you can see it at:
https://github.com/brave/brave-browser

@bsclifton bsclifton closed this Jul 13, 2018
@bsclifton bsclifton mentioned this pull request Jul 13, 2018
10 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants