This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 974
Implemented fix to show publisher toggle for PDFs #14028
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonrsadler
changed the title
Implemented fix to show publisher toggle
Implemented fix to show publisher toggle for PDFs
May 4, 2018
Codecov Report
@@ Coverage Diff @@
## master #14028 +/- ##
==========================================
- Coverage 56.51% 56.46% -0.05%
==========================================
Files 284 284
Lines 29357 29357
Branches 4880 4880
==========================================
- Hits 16590 16577 -13
- Misses 12767 12780 +13
|
Updated publisherToggle to grab the real URL lint Renamed publisherState name to publisherUtil
ryanml
approved these changes
May 4, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good fix, works well
jasonrsadler
pushed a commit
that referenced
this pull request
May 4, 2018
Implemented fix to show publisher toggle for PDFs
jasonrsadler
pushed a commit
that referenced
this pull request
May 4, 2018
Implemented fix to show publisher toggle for PDFs
10 tasks
NejcZdovc
added a commit
that referenced
this pull request
May 7, 2018
Added test for shouldShowPublisherButton for PR #14028
NejcZdovc
added a commit
that referenced
this pull request
May 7, 2018
Added test for shouldShowPublisherButton for PR #14028
NejcZdovc
added a commit
that referenced
this pull request
May 7, 2018
Added test for shouldShowPublisherButton for PR #14028
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14025
Payment button is still not being enabled after time requirements satisified.
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests