Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Added test for shouldShowPublisherButton for PR #14028 #14034

Merged
merged 1 commit into from
May 7, 2018
Merged

Added test for shouldShowPublisherButton for PR #14028 #14034

merged 1 commit into from
May 7, 2018

Conversation

jasonrsadler
Copy link
Contributor

@jasonrsadler jasonrsadler commented May 5, 2018 •
edited by NejcZdovc
Loading

Added test for shouldShowPublisherButton for PR #14028

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@jasonrsadler jasonrsadler self-assigned this May 5, 2018
@jasonrsadler jasonrsadler added this to the 0.22.x Release 3 (Beta channel) milestone May 5, 2018
@NejcZdovc
Copy link
Contributor

bat client library will be updated in this PR #14006. Let's limit this PR only on tests

Added test for shouldShowPublisherButton for PR #14028
c1560d1 
updated package-lock for npm 6. Updated bat-client for 2.2.8

Auditors:

Test Plan:

Auditors:

Test Plan:
NejcZdovc
NejcZdovc approved these changes May 7, 2018
View reviewed changes
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@NejcZdovc NejcZdovc merged commit 30cc25b into brave:master May 7, 2018
NejcZdovc added a commit that referenced this pull request May 7, 2018
@NejcZdovc
Merge pull request #14034 from jasonrsadler/test/#14028-pdf-url
6b2de53 
Added test for shouldShowPublisherButton for PR #14028
NejcZdovc added a commit that referenced this pull request May 7, 2018
@NejcZdovc
Merge pull request #14034 from jasonrsadler/test/#14028-pdf-url
d70c62b 
Added test for shouldShowPublisherButton for PR #14028
@NejcZdovc
Copy link
Contributor

master 30cc25b
0.23 6b2de53
0.22-release 3 d70c62b

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NejcZdovc NejcZdovc NejcZdovc approved these changes

Assignees

@jasonrsadler jasonrsadler

Labels
QA/no-qa-needed release-notes/exclude
Projects
None yet
Milestone
0.22.x Release 3 (Release Channel)
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonrsadler @NejcZdovc