Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Do not delete site data when no tags (history) #7239

Merged
merged 1 commit into from
Feb 14, 2017
Merged

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Feb 14, 2017

Test Plan:

Covered by automatic test

fix #7238

Auditors: @bsclfton, @bbondy

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

fix brave#7238

Auditors: @bsclfton, @bbondy

Test Plan:
Covered by automatic test
@darkdh darkdh added the bug label Feb 14, 2017
@darkdh darkdh added this to the 0.13.3 milestone Feb 14, 2017
@darkdh darkdh self-assigned this Feb 14, 2017
@bbondy
Copy link
Member

bbondy commented Feb 14, 2017

++ if there's no test for not deleting a history entry with tags though, then please add.

@bbondy bbondy merged commit a11ec89 into brave:master Feb 14, 2017
@bsclifton
Copy link
Member

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinned Tab and Bookmark Disappear after Deleting History
3 participants