Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add webdriver test to noScript exceptions #8838

Merged
merged 1 commit into from
May 24, 2017
Merged

Add webdriver test to noScript exceptions #8838

merged 1 commit into from
May 24, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 11, 2017

Follow up to #8783
Closes #8837

Auditors:

Test Plan:

  1. Run: BRAVE_TEST_COMMAND_LOGS=1 npm run test -- --grep='does not apply exceptions from private tabs to regular tabs'

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run indivually or as a suite ref

Follow up to #8783
Closes #8837

Auditors:

Test Plan:
1. Run: BRAVE_TEST_COMMAND_LOGS=1 npm run test -- --grep='does not apply exceptions from private tabs to regular tabs'
@luixxiul luixxiul self-assigned this May 11, 2017
@luixxiul luixxiul added this to the 0.15.400 milestone May 11, 2017
@bbondy
Copy link
Member

bbondy commented May 24, 2017

++ thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants