This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
make tab previews based on mouse idle time #8852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cezaraugusto
force-pushed
the
tabsbar/preview-timing
branch
from
f5f1c9a
to
668da6e
Compare
cezaraugusto
force-pushed
the
tabsbar/preview-timing
branch
from
668da6e
to
33d596e
Compare
cezaraugusto
force-pushed
the
tabsbar/preview-timing
branch
from
8ab0118
to
fc9790a
Compare
cezaraugusto
force-pushed
the
tabsbar/preview-timing
branch
from
fc9790a
to
1154bb3
Compare
|
setting to work in progress since we'll fully change how we deal with tab previews |
cezaraugusto
force-pushed
the
tabsbar/preview-timing
branch
4 times, most recently
from
7d4dab6
to
cabbc3e
Compare
cezaraugusto
changed the title
cezaraugusto
force-pushed
the
tabsbar/preview-timing
branch
from
cabbc3e
to
37f38f5
Compare
|
PR is still WIP as it needs Brad approval regarding preview timing but is ready for code review and feedback |
7 tasks
cezaraugusto
force-pushed
the
tabsbar/preview-timing
branch
from
37f38f5
to
276fac0
Compare
- Fix #8860 - Auditors: @bsclifton
cezaraugusto
force-pushed
the
tabsbar/preview-timing
branch
from
276fac0
to
3d87b1e
Compare
|
ok rebased |
alexwykoff
modified the milestones:
0.19.x,
0.17.x (Frozen, only critical adds from here)
bridiver
reviewed
Jun 20, 2017
| * | ||
| * @param {Boolean} shouldEnablePreview - true if user enters in previewMode state | ||
| */ | ||
| setPreviewMode: function (shouldEnablePreview) { |
There was a problem hiding this comment.
this action doesn't provide any new information that we don't already have in setPreviewFrame. We are already duplicating information in setTabHoverState and setPreviewFrame (fixed in #9542) and definitely don't want to add any more actions for this functionality
cezaraugusto
requested review from
bridiver
and removed request for
bradleyrichter,
bsclifton,
bbondy,
BrendanEich and
bridiver
|
moving to 0.18.x per last weekly triage meeting. WIP and blocked until #9542 lands, which is set for the same milestone. |
cezaraugusto
modified the milestones:
0.18.x (Developer Channel),
0.19.x (Nightly Channel)
|
am going to close this and keep as a ref and open a new one with updated logic |
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changed its purpose, please see description
Submitter Checklist:
git rebase -ito squash commits (if needed).Close #8860
Note for reviewers:
Previews are now happening based on mouse idle time. Which means that it will only be fired if you stay the mouse over a tab for a given amount of time -- which is defined in prefs->tabs.
Once the mouse is long enough over a tab and you wish to preview another tab, the preview is fired immediately. Once you leave the tab to another component, the event is canceled and you'll only be able to preview again if the mouse is idle again.
Test Plan:
Intentional preview
Unintentional preview/intentional preview
Dealing with options
Reviewer Checklist:
Tests