Directive refactoring #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will try to handle this PR tomorrow, it's too large for the current late-night round. |
Merged
jakobandersen
force-pushed
the
directive_refactoring
branch
from
b06df5b
to
9e69659
Compare
aprotyas
pushed a commit
to aprotyas/breathe
that referenced
this pull request
Aug 19, 2021
Note, both of these PRs are on top of the changes introduced by jakobandersen#698. Links to PRs for future reference: - breathe-doc#698 - breathe-doc#711 - breathe-doc#723 Signed-off-by: Abrar Rahman Protyasha <[email protected]>
aprotyas
pushed a commit
to aprotyas/breathe
that referenced
this pull request
Aug 19, 2021
Note, both of these PRs are on top of the changes introduced by upstream PR breathe-doc#698. Links to PRs for future reference: - breathe-doc#698 - breathe-doc#711 - breathe-doc#723 Signed-off-by: Abrar Rahman Protyasha <[email protected]>
jakobandersen
force-pushed
the
directive_refactoring
branch
from
9e69659
to
aa97f6f
Compare
|
This should be ready for review now. It's quite a lot of changes, so reviewing each commit in turn may be the easiest. |
michaeljones
approved these changes
Sep 1, 2021
|
Merge when you're happy @jakobandersen :) |
|
Thanks |
|
🎉 |
michaeljones
pushed a commit
that referenced
this pull request
Sep 14, 2021
This was referenced Feb 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not change any behaviour (tested with Breathes own documentation).
Merge
directive/anddirectives.pyinto adirectives/module with the directives in separate files based on their types.Note, the union directive is currently an "item" directive but should probably be changed to be a
class-likedirective so options like:members:become available. However, there is some strange namespacing rendering differences that needs to be ironed out first.