LPS-121875 Migrate management toolbar v2 usages in dynamic-data-mapping modules #99360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
Merged. Thank you. |
liferay-continuous-integration
deleted the
ci-forward-LPS-121875-2-pr-280-sender-markocikos-ts-1614625218084
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: liferay-data-engine#280 (Took 1
ci:forwardattempt in 1 minute)@markocikos
@liferay-data-engine
Original pull request comment:
Ticket: https://issues.liferay.com/browse/LPS-121875
In this PR we are migrating management toolbars in DDM modules to new tags based on Clay v3.
Initially I opened liferay-frontend#826, that branched into liferay-frontend#833 and this PR. We are using the newly minted
searchInputAutoFocusin this PR.Test plan is to ensure management toolbars maintain all features. The updated ones are on these pages:
There are two that I was not able to find in UI. Please test these thoroughly.
@ambrinchaudhary @jonmak08 @julien
Here is gif of those I was able to find:
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 91b812c23ec96d946f5dcf13449e4883d10f209e
Sender Branch:
Branch Name: LPS-121875-2
1 out of 1jobs PASSEDBranch GIT ID: 05382ce4538c70df9a878fab0415098742a83acd
1 Successful Jobs:
For more details click here.
✔️ ci:test:stable - 9 out of 9 jobs passed
✔️ ci:test:relevant - 26 out of 26 jobs passed in 2 hours 40 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 91b812c23ec96d946f5dcf13449e4883d10f209e
Upstream Comparison:
Branch GIT ID: 232b7029dbcc5cc632db42fdd9f88161634e3e96
Jenkins Build URL: Acceptance Upstream DXP (master) #1578
ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 26 out of 26 jobs PASSED
26 Successful Jobs:
For more details click here.