LPS-127020 Move autoFocus functionality to the management toolbar taglib #833

markocikos · 2021-02-23T14:45:27Z

Task ticket: https://issues.liferay.com/browse/LPS-127020
Related discussions:

Notes:

By default, we are not auto-focusing the search input. This is because Lexicon does not state this behavior and vast majorities on usages in DXP do not auto-focus. See [don't forward] LPS-121875 Migrate management toolbar v2 usages in dynamic-data-mapping-web #826 (comment)
There is an ongoing discussion about how to name the attribute, see [don't forward] LPS-121875 Migrate management toolbar v2 usages in dynamic-data-mapping-web #826 (comment). In this PR I chose searchInputAutoFocus because

<clay:management-toolbar
	searchInputAutoFocus="<%= true %>"
	searchInputName="mySearchInputName"
/>

rhymes with

<ClayInput
	autoFocus={searchInputAutoFocus}
	name={searchInputName}
/>

Intrestingly, React's autoFocus, capital F, is quite different from HTML autofocus. To prevent cross-browser inconsistencies, they are using a polyfill to call .focus().

/cc @wincent @4lejandrito @jbalsas @julien @jonmak08 @ambrinchaudhary

Test sample in clay-sample-web:

liferay-continuous-integration · 2021-02-23T14:45:42Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

liferay-continuous-integration · 2021-02-23T14:51:15Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 296e13564ebb4d8bc2666dccfdcd0bde44381fd1

Sender Branch:

Branch Name: LPS-127020
Branch GIT ID: 2d4bdf297489acce5d5d884f558ea7fc20feac51

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

wincent

I chose searchInputAutoFocus because

...

rhymes with

...

Sounds good enough reason to me!

liferay-continuous-integration · 2021-02-23T16:12:20Z

Jenkins Build:test-portal-source-format#4729
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-frontend#833
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - markocikos > liferay-frontend - PR#833 - 2021-02-23[06:47:31]
Spira Jenkins Build:publish-spira-report#14415

liferay-continuous-integration · 2021-02-23T18:22:41Z

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 20 out of 23 jobs passed in 1 hour 45 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1237401_7409

Base Branch:

Branch Name: master
Branch GIT ID: 296e13564ebb4d8bc2666dccfdcd0bde44381fd1

Upstream Comparison:

Branch GIT ID: 09206ef3a03ebcd6b1d9d18a76d736ee4745541a
Jenkins Build URL: Acceptance Upstream DXP (master) #1572

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 20 out of 23 jobs PASSED

3 Failed Jobs:

20 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
45 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=12,label_exp=!master #426448
  1. LocalFile.WebContentWithCustomStructures#AddWebContentWithRepeatableRichTextField - Poshi Report - Poshi Summary - Console Output

Failures in common with acceptance upstream results at 09206ef:

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #320198

Please fix semantic versioning on markocikos/LPS-127020

     [exec] 			+   return     int
     [exec] 		+   method     isShowButtons()
     [exec] 			+   return     boolean
     [exec] 		+   method     setAttributes(javax.servlet.http.HttpServletRequest)
     [exec] 			+   access     protected
     [exec] 			+   return     void
     [exec] 		+   method     setBackURL(java.lang.String)
     [exec] 			+   return     void
     [exec] 		+   method     setFormModelBean(java.lang.Object)
     [exec] 			+   return     void
     [exec] 		+   method     setFormName(java.lang.String)
     [exec] 			+   return     void
     [exec] 		+   method     setHtmlBottom(java.lang.String)
     [exec] 			+   return     void
     [exec] 		+   method     setHtmlTop(java.lang.String)
     [exec] 			+   return     void
     [exec] 		+   method     setId(java.lang.String)
     [exec] 			+   return     void
     [exec] 		+   method     setPageContext(javax.servlet.jsp.PageContext)
     [exec] 			+   return     void
     [exec] 		+   method     setShowButtons(boolean)
     [exec] 			+   return     void
     [exec] 		+   method     toString()
     [exec] 			+   return     java.lang.String
     [exec] 	<   class      com.liferay.frontend.taglib.servlet.taglib.SidebarPanelTag
     [exec] 		+   method     getCloseButton()
     [exec] 			+   return     boolean
     [exec] 		+   method     setCloseButton(boolean)
     [exec] 			+   return     void
     [exec] 	+   version    2.5.0
     [exec] 	-   version    2.6.0
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] 
     [exec] > Task :apps:frontend-taglib:frontend-taglib:syncVersions
     [exec] Gradle build finished at 2021-02-23 17:33:38.341.
     [exec] 
     [exec] 
     [exec] FAILURE: Build completed with 3 failures.
     [exec] 
     [exec] 1: Task failed with an exception.
     [exec] -----------
     [exec] * What went wrong:
     [exec] Execution failed for task ':apps:frontend-taglib:frontend-taglib-react:baseline'.
     [exec] > A failure occurred while executing com.liferay.gradle.plugins.baseline.internal.work.BaselineWorkAction
     [exec]    > org.gradle.api.GradleException: Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/tools/sdk/dist/com.liferay.frontend.taglib.react-5.0.0.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay/com.liferay.frontend.taglib.react/4.1.2/ec050fd1c3aa0f51ab209177255ba6f126eabeef/com.liferay.frontend.taglib.react-4.1.2.jar

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
45 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=14,label_exp=!master #426448
  1. LocalFile.Publications#PublishParallelPublications - Poshi Report - Poshi Summary - Console Output

liferay-continuous-integration · 2021-02-23T20:00:58Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#7409
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#833
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - markocikos > liferay-frontend - PR#833 - 2021-02-23[08:27:48]
Spira Jenkins Build:publish-spira-report#12127

julien

The changes LGTM; not sure about the test failure

markocikos · 2021-02-24T10:13:33Z

CI failure looks unrelated. I'll try to forward it. /cc @john-co

markocikos · 2021-02-24T10:13:54Z

ci:forward

liferay-continuous-integration · 2021-02-24T10:14:07Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2021-02-24T10:14:11Z

Skipping previously passed test suites:
ci:test:sf

kresimir-coko

liferay-continuous-integration · 2021-02-24T14:04:17Z

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 20 out of 23 jobs passed in 3 hours 10 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: bf41ac8d3aa2dbf64656fa7c0635882079d28f09

Upstream Comparison:

Branch GIT ID: bf41ac8d3aa2dbf64656fa7c0635882079d28f09
Jenkins Build URL: Acceptance Upstream DXP (master) #1575

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 20 out of 23 jobs PASSED

3 Failed Jobs:

20 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

15 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=14,label_exp=!master #1982

 [parallel] 	at com.mysql.cj.protocol.StandardSocketFactory.performTlsHandshake(StandardSocketFactory.java:188)
 [parallel] 	at com.mysql.cj.protocol.a.NativeSocketConnection.performTlsHandshake(NativeSocketConnection.java:99)
 [parallel] 	at com.mysql.cj.protocol.a.NativeProtocol.negotiateSSLConnection(NativeProtocol.java:325)
 [parallel] 	... 20 more
 [parallel] Stopping the server due to unexpected startup errors
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/jps_output
[stopwatch] [run.batch.test.action: 17:39.220 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:365: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1594: /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1598: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:50: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:62: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:13281: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:13653: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:4378: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:4479: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:5602: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:5760: Unable to find startup message after 30 minutes.
     [echo] ${jstack.output}
      [get] Getting: http://test-1-2/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=14,label_exp=!master/1982//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20210224053113320.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20210224053113320.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null1195029904.properties

Failures in common with acceptance upstream results at bf41ac8:

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #1980

Please fix semantic versioning on markocikos/LPS-127020

     [exec]   com.liferay.frontend.taglib.clay.data.set          UNCHANGED  1.1.0      1.1.1      1.1.1      VERSION INCREASE SUGGESTED
     [exec] 	+   version    1.1.0
     [exec] 	-   version    1.1.1
     [exec]   com.liferay.frontend.taglib.clay.data.set.provider UNCHANGED  1.0.0      1.0.1      1.0.1      VERSION INCREASE SUGGESTED
     [exec] 	+   version    1.0.0
     [exec] 	-   version    1.0.1
     [exec] * com.liferay.frontend.taglib.clay.servlet.taglib.display.context MINOR      1.5.0      1.5.0      1.6.0      VERSION INCREASE REQUIRED
     [exec] 	<   interface  com.liferay.frontend.taglib.clay.servlet.taglib.display.context.ManagementToolbarDisplayContext
     [exec] 		+   method     isSearchInputAutoFocus()
     [exec] 			+   return     java.lang.Boolean
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] 
     [exec] > Task :apps:frontend-taglib:frontend-taglib-clay:syncVersions
     [exec] 
     [exec] > Task :apps:frontend-taglib:frontend-taglib:compileJSP
     [exec] Note: Some input files use or override a deprecated API.
     [exec] Note: Recompile with -Xlint:deprecation for details.
     [exec] Note: Some input files use unchecked or unsafe operations.
     [exec] Note: Recompile with -Xlint:unchecked for details.
     [exec] 
     [exec] > Task :apps:frontend-taglib:frontend-taglib:jar
     [exec] > Task :apps:frontend-taglib:frontend-taglib:autoUpdateXml SKIPPED
     [exec] > Task :apps:frontend-taglib:frontend-taglib:baseline
     [exec] > Task :apps:frontend-taglib:frontend-taglib:syncVersions
     [exec] Gradle build finished at 2021-02-24 13:03:43.151.
     [exec] 
     [exec] 
     [exec] FAILURE: Build completed with 2 failures.
     [exec] 
     [exec] 1: Task failed with an exception.
     [exec] -----------
     [exec] * What went wrong:
     [exec] Execution failed for task ':apps:frontend-taglib:frontend-taglib-react:baseline'.
     [exec] > A failure occurred while executing com.liferay.gradle.plugins.baseline.internal.work.BaselineWorkAction
     [exec]    > org.gradle.api.GradleException: Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/tools/sdk/dist/com.liferay.frontend.taglib.react-5.0.0.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay/com.liferay.frontend.taglib.react/4.1.2/ec050fd1c3aa0f51ab209177255ba6f126eabeef/com.liferay.frontend.taglib.react-4.1.2.jar

wincent · 2021-02-24T14:29:52Z

Stopping the server due to unexpected startup errors

I think we can forward this manually. The other failure you saw was a known issue, fixed yesterday.

wincent · 2021-02-24T14:33:12Z

Life is too short. Manual forward: brianchandotcom#99157

liferay-continuous-integration · 2021-02-24T14:58:20Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#7967
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#833
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - markocikos > liferay-frontend - PR#833 - 2021-02-24[02:53:19]
Spira Jenkins Build:publish-spira-report#16315

markocikos added 2 commits February 23, 2021 15:05

LPS-127020 Add attribute to set auto-focus on search input

dbd3de5

LPS-127020 Add sample use of auto-focus on search input

2d4bdf2

markocikos requested a review from wincent February 23, 2021 14:45

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Feb 23, 2021

wincent approved these changes Feb 23, 2021

View reviewed changes

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Feb 23, 2021

julien reviewed Feb 24, 2021

View reviewed changes

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending and removed ci:test:relevant - failure ci:test:stable - success labels Feb 24, 2021

kresimir-coko approved these changes Feb 24, 2021

View reviewed changes

liferay-continuous-integration added ci:test:relevant - failure and removed ci:test:relevant - pending labels Feb 24, 2021

liferay-continuous-integration added ci:test:stable - success and removed ci:test:stable - pending labels Feb 24, 2021

wincent mentioned this pull request Feb 24, 2021

LPS-127020 Move autoFocus functionality to the management toolbar taglib brianchandotcom/liferay-portal#99157

Closed

wincent closed this Feb 24, 2021

markocikos mentioned this pull request Feb 25, 2021

LPS-121875 Migrate management toolbar v2 usages in dynamic-data-mapping modules liferay-data-engine/liferay-portal#280

Closed

julien mentioned this pull request Feb 26, 2021

LPS-121903 Migrate v2 usages in roles/roles-admin-web #835

Closed

liferay-continuous-integration mentioned this pull request Mar 1, 2021

LPS-121875 Migrate management toolbar v2 usages in dynamic-data-mapping modules brianchandotcom/liferay-portal#99360

Closed

markocikos deleted the LPS-127020 branch July 15, 2021 11:41

LPS-127020 Move autoFocus functionality to the management toolbar taglib #833

LPS-127020 Move autoFocus functionality to the management toolbar taglib #833

Conversation

markocikos commented Feb 23, 2021

liferay-continuous-integration commented Feb 23, 2021

liferay-continuous-integration commented Feb 23, 2021

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Base Branch:

Sender Branch:

For more details click here.

wincent left a comment

Choose a reason for hiding this comment

liferay-continuous-integration commented Feb 23, 2021

liferay-continuous-integration commented Feb 23, 2021

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 20 out of 23 jobs passed in 1 hour 45 minutes

Base Branch:

Upstream Comparison:

3 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

liferay-continuous-integration commented Feb 23, 2021

julien left a comment

Choose a reason for hiding this comment

markocikos commented Feb 24, 2021

markocikos commented Feb 24, 2021

liferay-continuous-integration commented Feb 24, 2021

liferay-continuous-integration commented Feb 24, 2021

kresimir-coko left a comment

Choose a reason for hiding this comment

liferay-continuous-integration commented Feb 24, 2021

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 20 out of 23 jobs passed in 3 hours 10 minutes

Base Branch:

Upstream Comparison:

3 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0

Job Results:

wincent commented Feb 24, 2021

wincent commented Feb 24, 2021

liferay-continuous-integration commented Feb 24, 2021