Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(terraform_plan): support jsonpath queries in AWS IAM policy strings for Terraform plan #4033

Merged
merged 2 commits into from
Dec 12, 2022
Merged

feat(terraform_plan): support jsonpath queries in AWS IAM policy strings for Terraform plan #4033

merged 2 commits into from
Dec 12, 2022

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Dec 10, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • added an extra behaviour for specific fields in AWS IAM resources to transform the strings to dict
  • due to performance implications it is only done for the resource types and the specific field
  • had to fork jsonpath-ng and fix an issue, which didn't allow filtering on a single dict

Fixes #4032

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

rotemavni
rotemavni approved these changes Dec 11, 2022
View reviewed changes
Copy link
Collaborator

@rotemavni rotemavni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 💅

@gruebel gruebel mentioned this pull request Dec 11, 2022
Merged
7 tasks
@gruebel gruebel merged commit 585c865 into bridgecrewio:main Dec 12, 2022
@gruebel gruebel deleted the support-jsonpath-tfplan branch December 12, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rotemavni rotemavni rotemavni approved these changes

@tronxd tronxd tronxd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terraform plan: Support jsonpath queries in AWS IAM policy fields
3 participants
@gruebel @tronxd @rotemavni