chore: replace deprecated LegacyVersion with own one #4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matansha
reviewed
Dec 12, 2022
checkov/common/packaging/version.py
Outdated
| return False | ||
|
|
||
|
|
||
| _legacy_version_component_re = re.compile(r"(\d+ | [a-z]+ | \.| -)", re.VERBOSE) |
There was a problem hiding this comment.
are the spaces part of the regular expression?
also, i suggest to add flag for case insensitive
There was a problem hiding this comment.
the spaces don't seem to do anything for this use case, just kept them as they were. but will add ignorecase to it
There was a problem hiding this comment.
Are you sure? the space are meaningful in regex. did you check this? if yes, i will approve it
There was a problem hiding this comment.
yeap, I tested it. It didn't change the output with or without the spaces.
There was a problem hiding this comment.
in general you are right that spaces are meaningful, but not for what it is used here
matansha
reviewed
Dec 12, 2022
matansha
approved these changes
Dec 12, 2022
gruebel
added a commit
to gruebel/checkov
that referenced
this pull request
Dec 12, 2022
* replace depreacted LegacyVersion with own one * upgrade to latest packaging version * fix mypy * fix linting * add ignorecase flag
gruebel
added a commit
to gruebel/checkov
that referenced
this pull request
Dec 12, 2022
* replace depreacted LegacyVersion with own one * upgrade to latest packaging version * fix mypy * fix linting * add ignorecase flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Checklist: