Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a mergeWithRemapping() method in ReferenceConfidenceVariantContextMerger to perform allele remapping prior to genotyping #8318

Merged
merged 1 commit into from
May 17, 2023

Conversation

droazen
Copy link
Contributor

@droazen droazen commented May 12, 2023

This is intended to tide the GVS team over until #8317 is fixed.

…tMerger to perform allele remapping prior to genotyping

This is intended to tide the GVS team over until #8317 is fixed.
@droazen
Copy link
Contributor Author

droazen commented May 12, 2023

@mcovarr Could you please try the new ReferenceConfidenceVariantContextMerger.mergeWithRemapping() method out in the GVS branch, and report whether your tests pass? Should be a drop-in replacement for ReferenceConfidenceVariantContextMerger.merge().

Once #8317 is fixed, we'll make this behavior the default and ask you to switch back to merge(), as discussed recently.

@droazen
Copy link
Contributor Author

droazen commented May 12, 2023

@ldgauthier At some point I'd like to discuss both this PR and #8317 with you

@gatk-bot
Copy link

gatk-bot commented May 12, 2023

Github actions tests reported job failures from actions build 4962783051
Failures in the following jobs:

Test Type JDK Job ID Logs
cloud 17.0.6+10 4962783051.10 logs
cloud 17.0.6+10 4962783051.10 logs
cloud 17.0.6+10 4962783051.10 logs
cloud 17.0.6+10 4962783051.10 logs

@droazen
Copy link
Contributor Author

droazen commented May 12, 2023

(Note that the failure in the cloud tests is expected due to an ongoing GCS bucket region migration -- it should clear up next week)

Copy link
Collaborator

@mcovarr mcovarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! Confirmed that mergeWithRemapping works on the GVS / master branch here.

@droazen
Copy link
Contributor Author

droazen commented May 17, 2023

Merging this one despite the ongoing failure in the cloud tests, which is understood and known to be unrelated.

@droazen droazen merged commit b013901 into master May 17, 2023
@droazen droazen deleted the dr_gvs_allele_remapping_toggle branch May 17, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants