Added tests for FutureGetBestBlockHashResult.Receive #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One test per PR to keep them small makes perfect sense to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a few tests to cover
func (f FutureGetBestBlockHashResult) Receive(). I've noticed thatrpcclienthas 0.6% test coverage (before this PR):this PR bumps it up to 0.9%
$ go-acc ./rpcclient ok github.com/btcsuite/btcd/rpcclient 0.234s coverage: 0.9% of statements in ./rpcclientI want to keep adding tests but I want to do them in their own PRs: as some tests will be larger than others, I don't want the PR(s) to be too big and unreadable.