-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added test for client.GetChainTxStatsAsync() in rpcclient. #2049
Added test for client.GetChainTxStatsAsync() in rpcclient. #2049
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the addition of a test but looks like the actions are failing.
Could you fix those please?
9da4049
to
62f4a20
Compare
Hey @jcvernaleo , my apologies, I had forgotten to add the websocket module to btcutil/go.sum, resulting in errors from errors found here and here both result from that not being found in the I have run both |
Pull Request Test Coverage Report for Build 6725208065
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Code looks good but there is a conflict after the previous PR went in. If you could fix conflict, I'll approve and merge.
Sorry about that!
62f4a20
to
ae1dde5
Compare
…up a test websocket server to run the tests. Also, ensure these are run within a timeout, since they rely on concurrency
ae1dde5
to
9dde0b7
Compare
Hey @jcvernaleo , I just rebased and pushed, everything should be up-to-date now 👍 thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Added test for client.GetChainTxStatsAsync() in rpcclient. This sets up a test websocket server to run the tests. Also, ensure these are run within a timeout, since they rely on concurrency.
Similar to this other pull request, these changes increase the code coverage for rpcclient tests to 5.3%
go-acc ./rpcclient/ ok github.com/btcsuite/btcd/rpcclient 0.255s coverage: 5.3% of statements in ./rpcclient/