Fix disabling/re-enabling ANR after initialization #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
suggested changes
May 27, 2021
kstenerud
force-pushed
the
6620-disable-enable-anr
branch
from
387edef
to
a2f93ba
Compare
|
@kstenerud A changelog entry also needs adding |
|
OK, I wasn't sure if we needed an entry here or in Unity since the Android library has no public API for enabling/disabling. |
kstenerud
force-pushed
the
6620-disable-enable-anr
branch
from
a2f93ba
to
54130ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
PLAT-6620
ANRs were not being re-enabled after being disabled via the API.
Design
Don't exit the watchdog thread anymore. Just loop to the next thread wait point and then after being triggered, only do ANR processing if ANRs are currently enabled.
Testing
Ran in a unity project that disables and enables error and ANR processing.