Release v7.11.0 #1484
Merged
Release v7.11.0 #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deps(react-native): Update bugsnag-cocoa to v6.10.1
…rrors-false [PLAT-6174] feat: Ensure server plugins honour autoDetectErrors option
The intended behaviour of enabledBreadcrumbTypes is for breadcrumbs to be left when it is null. This allows notifiers to avoid creating a set of breadcrumb types when it is not necessary The latest Android release changed enabledBreadcrumbTypes to null by default for performance reasons and uncovered this bug via the RN tests
Leave autotomatic breadcrumbs when `enabledBreadcrumbTypes` is null
…mb-types-is-null Fix crashes when `enabledBreadcrumbTypes` is null
Add `_isBreadcrumbTypeEnabled` helper to core
deps(react-native): Update bugsnag-cocoa to v6.10.2
Bump bugsnag-android to v5.10.0
Bump bugsnag-android to v5.10.1
Fix internal type definition for session delegates
Koa internally wraps thrown non-Errors in an Error instance, which means we no longer detect a non-Error in Bugsnag This doesn't seem like a problem as it's still clearly not an Error instance originally: > non-error thrown: "<thing that was thrown>"
There's no need to attach metadata if ctx.bugsnag exists as we know we have added an onError callback to record the metadata already This was previously required as the errorHandler and requestHandler were totally independant
We no longer set the status code internally, but Koa does this in its error handler so we don't need to anymore
Koa doesn't add its own error handler if another handler has been added already. We don't want to suppress the default handler just by adding Bugsnag, so we need to manually call the built-in handler However, if another handler has already been added then we don't want to call the default as that is also a change in behaviour
Fix the Koa plugin suppressing other error handlers
|
| Minified | Minfied + Gzipped | |
|---|---|---|
| Before | 41.31 kB |
12.71 kB |
| After | 41.24 kB |
12.71 kB |
| ± | -78 bytes |
+6 bytes |
code coverage diff
| Ok | File | Lines | Branches | Functions | Statements |
|---|---|---|---|---|---|
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/core/client.js | 99.35% (+0.01%) |
97.62% (+0.06%) |
100% (+0%) |
98.8% (+0.01%) |
| 🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/electron/src/client/renderer.js | 34.38% (-1.1%) |
0% (+0%) |
0% (+0%) |
30.56% (-0.87%) |
| 🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-console-breadcrumbs/console-breadcrumbs.js | 100% (+0%) |
85.71% (-0.96%) |
100% (+0%) |
100% (+0%) |
| 🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-express/src/express.js | 25.64% (-1.39%) |
0% (+0%) |
12.5% (+0%) |
23.81% (-2.51%) |
| 🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-interaction-breadcrumbs/interaction-breadcrumbs.js | 78.13% (-0.66%) |
57.14% (-2.32%) |
100% (+0%) |
69.77% (-0.68%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-koa/src/koa.js | 82.05% (+26.73%) |
81.25% (+53.98%) |
71.43% (+14.29%) |
82.05% (+26.95%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-koa/src/request-info.js | 100% (+0%) |
78.95% (+5.27%) |
100% (+0%) |
88.89% (+0%) |
| 🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-navigation-breadcrumbs/navigation-breadcrumbs.js | 86.05% (-0.31%) |
59.26% (-2.81%) |
71.43% (+0%) |
83.02% (-0.31%) |
| 🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-network-breadcrumbs/network-breadcrumbs.js | 98.65% (+0%) |
88.64% (-0.49%) |
100% (+0%) |
98.72% (+0%) |
| 🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-react-native-orientation-breadcrumbs/orientation.js | 94.12% (+0%) |
87.5% (-2.5%) |
100% (+0%) |
94.44% (+0%) |
| 🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-react-navigation/react-navigation.js | 100% (+0%) |
94.44% (-0.56%) |
100% (+0%) |
100% (+0%) |
| 🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-restify/src/restify.js | 24.39% (-1.25%) |
0% (+0%) |
12.5% (+0%) |
22.22% (-2.17%) |
| 🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/react-native/src/notifier.js | 72.15% (+0.36%) |
61.76% (-0.74%) |
61.54% (+0%) |
71.26% (+0.33%) |
Total:
| Lines | Branches | Functions | Statements |
|---|---|---|---|
| 82.58%(+0.2%) | 72.02%(+0.11%) | 83.57%(+0.1%) | 81.56%(+0.13%) |
imjoehaines
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
autoDetectErrorsconfiguration option #1464Changed
BSGAppHangDetector. bugsnag-cocoa#1153userinformation frommetaData. bugsnag-cocoa#1151+[BugsnagThread allThreadsWithCurrentThreadBacktrace:]. bugsnag-cocoa#1148NSNullhandling in+[BugsnagError errorFromJson:]and+[BugsnagStackframe frameFromJson:]. bugsnag-cocoa#1143bsg_ksmachgetThreadQueueName. bugsnag-cocoa#1147calloc()tomalloc()in NDK codebugsnag-android#1320
bugsnag-android#1322
bugsnag-android#1318
bugsnag-android#1303
bugsnag-android#1292
bugsnag-android#1311
bugsnag-android#1310
bugsnag-android#1315
bugsnag-android#1316
bugsnag-android#1265
bugsnag-android#1275
bugsnag-android#1276
bugsnag-android#1274
bugsnag-android#1277
bugsnag-android#1281
bugsnag-android#1279
bugsnag-android#1282
bugsnag-android#1280
bugsnag-android#1283
app.binaryArchin all eventsbugsnag-android#1287
bugsnag-android#1288
bugsnag-android#1286
bugsnag-android#1289
bugsnag-android#1293
bugsnag-android#1300
Fixed
enabledBreadcrumbTypesisnull#1466enabledBreadcrumbTypesisnull#1467