Register system callbacks on background thread #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
offload-init-work
branch
2 times, most recently
from
1768edd
to
f61b285
Compare
lemnik
approved these changes
Jun 24, 2021
bugsnag-android-core/src/main/java/com/bugsnag/android/SystemBroadcastReceiver.kt
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/SystemBroadcastReceiver.kt
Show resolved
Hide resolved
fractalwrench
force-pushed
the
offload-init-work
branch
8 times, most recently
from
3b759bb
to
b973581
Compare
fractalwrench
force-pushed
the
offload-init-work
branch
from
b973581
to
f1190ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Registers callbacks on a background thread to avoid unnecessary work in the
Clientconstructor. This saves approximately ~10ms when callingBugsnag.start().Changeset
Registered the following on the background thread:
SystemBroadcastReceiver, which receives intents that are turned into breadcrumbsConverted
SystemBroadcastReceiverto kotlin while making changes. It's also worth noting that some methods are package visible to prevent the creation of synthetic accessors.Testing
Relied on existing test coverage, and ran an example app to test orientation/connectivity/system broadcast changes