Prefer calloc() to malloc() in NDK code #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
PLAT-7000/prefer-calloc-to-malloc
branch
from
de75f27
to
7c5bca4
Compare
fractalwrench
force-pushed
the
PLAT-7000/prefer-calloc-to-malloc
branch
from
7c5bca4
to
de2b72c
Compare
kstenerud
approved these changes
Jul 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Use
calloc()rather thanmalloc()in NDK code wherever this is possible.calloc()ensures that the bytes will always be set to zero before they are read, which ensures there is no possibility of junk data being included in thebsg_eventstruct and leading to undefined behaviour.Testing
Relied on existing test coverage.