Remove all categories to avoid linker problems #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstenerud
force-pushed
the
6616-remove-categories
branch
from
ca471d8
to
d32a304
Compare
kattrali
approved these changes
May 25, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The xcode linker fails to link categories when building a static library unless the end-user puts in special linker flags. Rather than require extra steps by the user, just remove all category code from Bugsnag.
Changeset
Removed all category code and merged it into their respective main ObjC files (marked with pragmas).
NSError convenience constructors have been moved to a placeholder class
NSErrorBSGwhose only purpose is to house the NSError constructors.Testing
Re-ran e2e tests