Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-6679] Remove remaining category #1117

Merged
merged 2 commits into from
Jun 10, 2021
Merged

[PLAT-6679] Remove remaining category #1117

merged 2 commits into from
Jun 10, 2021

Conversation

nickdowell
Copy link
Contributor

Goal

Finish the removal of categories started in #1098

Changeset

Removes the BSGKSMerge category on NSDictionary that was not actually being used anywhere ¯\_(ツ)_/¯

Removes the dedicated header files that declared the categories removed by #1098 to ensure that a missing implementation of one of those methods will trigger a compiler warning / error.

Testing

Tested via unit and E2E tests

@github-actions
Copy link

github-actions bot commented Jun 9, 2021

Infer: No issues found 🎉

OCLint: No issues found 🎉

Bugsnag.framework binary size increased by 376 bytes from 1,125,592 to 1,125,968

Generated by 🚫 Danger

@nickdowell nickdowell merged commit ee90d64 into next Jun 10, 2021
@nickdowell nickdowell deleted the remove-category branch June 10, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants