Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fix a crash that can occur when uploading events that contain a
null
/NSNull
stacktrace value.See #1138
Changeset
+[BugsnagError errorFromJson:]
and+[BugsnagStackframe frameFromJson:]
now use theBSGDeserialize...
functions to check the value types when deserializing from JSON.BSGEventUploadOperation
now encapsulates the main logic in a@try ... @catch
block to prevent crashes, and reports any caught exceptions to Bugsnag using the internal error reporting mechanism.Testing
Unit tests have been amended to verify correct handling of
NSNull
values.