Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-6944] Remove (duplicated) user information from metaData #1151

Merged
merged 2 commits into from
Jul 8, 2021

Conversation

nickdowell
Copy link
Contributor

Goal

An event's metaData would under some circumstances contain a user payload which could contain out of date information, breaking event filters on the dashboard.

Changeset

User data is no longer copied into the metadata by BugsnagConfiguration

Testing

Updated E2E tests to verify that metaData.user does not contain information copied from the user payload, but that setting a custom user payload works as expected.

Ran full E2E test suite to verify no failures are introduced.

@github-actions
Copy link

github-actions bot commented Jul 8, 2021

Infer: No issues found 🎉

OCLint: No issues found 🎉

Bugsnag.framework binary size decreased by 144 bytes from 1,134,024 to 1,133,880 🎉

Generated by 🚫 Danger

@nickdowell nickdowell merged commit 201543d into next Jul 8, 2021
@nickdowell nickdowell deleted the nickdowell/user-metadata branch July 8, 2021 12:12
@nickdowell nickdowell mentioned this pull request Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants