Fixes issue when using Bugsnag on a WatchOS app #1583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was trying to access an extension but on latest WatchOS we can have a standalone app.
clr182
added
feature request
|
+1 for this fix. I noticed the SDK works fine with watch targets created prior to Xcode 14, but new targets and consolidated targets will crash. |
|
Thanks @gpambrozio - the fix looks good. We're going to carry it on in #1588 to allow CI to run and to merge it down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was trying to access an extension but on latest WatchOS we can have a standalone app. Related to this issue
Goal
Not crash when using Bugsnag on a standalone Apple watch app.
Design
Just added some checks to see if code is running on an app or extension.
Testing
See steps in related issue. With this branch the crash does not happen.