Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue when using Bugsnag on a WatchOS app #1588

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Fixes issue when using Bugsnag on a WatchOS app #1588

merged 3 commits into from
Nov 10, 2023

Conversation

tomlongridge
Copy link
Contributor

@tomlongridge tomlongridge commented Oct 11, 2023 •
edited by kstenerud
Loading

Update WatchOS code to handle the newer application setup rather than always assuming an extension.

@github-actions
Copy link

github-actions bot commented Oct 11, 2023 •
edited
Loading

Bugsnag.framework binary size did not change - 713,248 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Generated by 🚫 Danger

@tomlongridge tomlongridge mentioned this pull request Oct 11, 2023
Closed
@kstenerud kstenerud changed the base branch from master to next November 7, 2023 12:26
@kstenerud kstenerud force-pushed the gpambrozio/watchapp-fix branch 3 times, most recently from 1778920 to 7afdf35 Compare November 9, 2023 13:24
@kstenerud kstenerud mentioned this pull request Nov 9, 2023
Merged
gpambrozio and others added 2 commits November 10, 2023 09:35
@gpambrozio @kstenerud
Fixes issue when using Bugsnag on a WatchOS app
1db81a4 
The code was trying to access an extension but on latest WatchOS we can have a standalone app.
@kstenerud
WKApplication is only available on WatchOS 7+
2144572
@kstenerud kstenerud force-pushed the gpambrozio/watchapp-fix branch 3 times, most recently from 1d11c65 to 5206153 Compare November 10, 2023 14:15
@kstenerud kstenerud marked this pull request as ready for review November 10, 2023 14:47
tomlongridge
tomlongridge commented Nov 10, 2023
View reviewed changes
Copy link
Contributor Author

@tomlongridge tomlongridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kstenerud kstenerud merged commit d2c982b into next Nov 10, 2023
41 checks passed
@kstenerud kstenerud deleted the gpambrozio/watchapp-fix branch November 10, 2023 15:36
@kstenerud kstenerud mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kstenerud kstenerud kstenerud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomlongridge @kstenerud @gpambrozio