-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
watchos testing fixes #1605
Merged
Merged
watchos testing fixes #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
kstenerud
force-pushed
the
karl-watchos-testing-fixes
branch
from
November 9, 2023 14:41
641357f
to
56d796c
Compare
kstenerud
force-pushed
the
karl-watchos-testing-fixes
branch
from
November 9, 2023 14:49
56d796c
to
2769b60
Compare
kstenerud
requested review from
twometresteve,
tomlongridge and
robert-smartbear
November 9, 2023 15:15
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test/CI changes look fine to me.
tomlongridge
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fixes to get watchOS tests working again.
These are cherry-picked out of #1588 and will be rebased back in once we have a working baseline.
Commit 2769b60 makes sure that the mach headers list is initialized before any other code runs. This code is called by
BSGCrashSentryInstall()
inBugsnagClient.m
, but by then it's already too late becauseBSGRunContextInit()
will have already tried to fetch the info from it. Reversing the call order ofBSGCrashSentryInstall
andBSGRunContextInit
won't work either, as they have reciprocal dependencies, so swapping them will just break other things. This is the least invasive way to reconcile it sincebsg_mach_headers_initialize()
is idempotent. A full solution would move to a phased startup architecture like in bugsnag-cocoa-performance: init, configure, start - but that would be a biiiig project!Incidentally, this last commit should also fix the mach-o UUID issue (it was failing because the mach headers list was not initialized yet), but I haven't tested that extensively to be 100% sure it fixes everything.