Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watchos testing fixes #1605

Merged
merged 7 commits into from
Nov 9, 2023
Merged

watchos testing fixes #1605

merged 7 commits into from
Nov 9, 2023

Conversation

kstenerud
Copy link
Contributor

@kstenerud kstenerud commented Nov 9, 2023

Goal

Fixes to get watchOS tests working again.

These are cherry-picked out of #1588 and will be rebased back in once we have a working baseline.

Commit 2769b60 makes sure that the mach headers list is initialized before any other code runs. This code is called by BSGCrashSentryInstall() in BugsnagClient.m, but by then it's already too late because BSGRunContextInit() will have already tried to fetch the info from it. Reversing the call order of BSGCrashSentryInstalland BSGRunContextInit won't work either, as they have reciprocal dependencies, so swapping them will just break other things. This is the least invasive way to reconcile it since bsg_mach_headers_initialize() is idempotent. A full solution would move to a phased startup architecture like in bugsnag-cocoa-performance: init, configure, start - but that would be a biiiig project!

Incidentally, this last commit should also fix the mach-o UUID issue (it was failing because the mach headers list was not initialized yet), but I haven't tested that extensively to be 100% sure it fixes everything.

@kstenerud kstenerud changed the base branch from master to next November 9, 2023 14:23
Copy link

github-actions bot commented Nov 9, 2023

Bugsnag.framework binary size did not change - 713,248 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +4  +0.0%      +4    __TEXT,__text
  -0.0%      -4  -0.0%      -4    [__TEXT]
  [ = ]       0  [ = ]       0    TOTAL

Generated by 🚫 Danger

@kstenerud kstenerud marked this pull request as ready for review November 9, 2023 15:15
Copy link
Contributor

@twometresteve twometresteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test/CI changes look fine to me.

@tomlongridge tomlongridge changed the title Karl watchos testing fixes watchos testing fixes Nov 9, 2023
@kstenerud kstenerud merged commit 0218b12 into next Nov 9, 2023
41 checks passed
@kstenerud kstenerud deleted the karl-watchos-testing-fixes branch November 9, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants