Leave autotomatic breadcrumbs when enabledBreadcrumbTypes is null
#1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intended behaviour of enabledBreadcrumbTypes is for breadcrumbs to be left when it is null. This allows notifiers to avoid creating a set of breadcrumb types when it is not necessary The latest Android release changed enabledBreadcrumbTypes to null by default for performance reasons and uncovered this bug via the RN tests
|
| Minified | Minfied + Gzipped | |
|---|---|---|
| Before | 41.31 kB |
12.71 kB |
| After | 41.31 kB |
12.72 kB |
| ± | -1 bytes |
+8 bytes |
code coverage diff
Coverage values did not change👌.
Total:
| Lines | Branches | Functions | Statements |
|---|---|---|---|
| 82.27%(+0%) | 71.48%(+0%) | 83.47%(+0%) | 81.21%(+0.01%) |
kattrali
approved these changes
Jul 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The intended behaviour of
enabledBreadcrumbTypesis for breadcrumbs to be left when it is null. This allows notifiers to avoid creating a set of breadcrumb types when it is not necessaryThe latest Android release changed
enabledBreadcrumbTypesto null by default for performance reasons and uncovered this bug via the RN testsNote that this PR doesn't fix the problem alone as some parts of the code do not handle the case where
enabledBreadcrumbTypesis null and so will crash whennotifyis called. This will be fixed in #1467Testing
Covered by existing tests and new unit tests for the
nullcase. This cannot be manually tested yet asnotifyfails whenenabledBreadcrumbTypesis null