Fix in-flight being unable to track event requests made by cloned clients #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djskinner
approved these changes
Dec 6, 2022
imjoehaines
force-pushed
the
clone-client-unit-tests
branch
from
6d1f9b6
to
5e3494a
Compare
This allows plugins to make changes to any new clones, which may be necessary if they are monkey patching clients
clone-client doesn't copy over monkey patched methods on to new clones¹, so we have to hook into the cloning process to monkey patch them ¹ This is actually a good thing as monkey patched methods will usually work by holding a reference to an old client to call the un-patched method. If we copied them over then they would still reference the original client, not the clone
imjoehaines
force-pushed
the
in-flight-cloned-clients
branch
from
6b35ba1
to
65642a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The in-flight package was unable to track event requests made by cloned clients because the
_notifymonkey patch was not copied over to the clones. This is actually a good thing because the monkey patch holds onto a reference to the original client, so it would have been broken even if the clone got the patchI've added support for "on clone callbacks" in clone-client, which other packages can register to be notified when a client is cloned. The in-flight package can then register a callback to patch any new clones
This was only a problem for events as the session request tracking is done via the session delegate and this is copied straight onto the clone, so is shared by both clients