Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix in-flight being unable to track event requests made by cloned clients #1881

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Fix in-flight being unable to track event requests made by cloned clients #1881

merged 2 commits into from
Dec 7, 2022

Commits on Dec 6, 2022

  1. Add support for registering callbacks when cloning 

    This allows plugins to make changes to any new clones, which may be
necessary if they are monkey patching clients
    @imjoehaines
    imjoehaines committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    259882b View commit details
    Browse the repository at this point in the history

  2. Ensure notify is patched when a client is cloned 

    clone-client doesn't copy over monkey patched methods on to new clones¹,
so we have to hook into the cloning process to monkey patch them

¹ This is actually a good thing as monkey patched methods will usually
work by holding a reference to an old client to call the un-patched
method. If we copied them over then they would still reference the
original client, not the clone
    @imjoehaines
    imjoehaines committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    65642a8 View commit details
    Browse the repository at this point in the history