feat(node): Use util.inspect() before printing non-errors #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djskinner
approved these changes
Jan 8, 2020
throw { ... } or reject({ ... }) is bad practice, but sometimes it happens. Previously (as
highlighted in #597), Bugsnag would just print [object Object], which is unhelpful. This
uses util.inspect() to get a better textual representation of anything that doesn't have
a .stack property, before logging it to the console.
Parially fixes #597
bengourley
force-pushed
the
node-print-non-error
branch
from
ea3ca4b
to
d82dc80
Compare
|
Rebased against |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
throw { ... }orreject({ ... })is bad practice, but sometimes it happens. Previously (ashighlighted in #597), Bugsnag would just print
[object Object], which is unhelpful. Thisuses util.inspect() to get a better textual representation of anything that doesn't have
a .stack property, before logging it to the console.
Partially fixes #597 (work on the
v7branch addresses the part that affects the error report).